feat: add sandbox port sharing to public sdk - #9
Merged
Conversation
Expose a typed sharePort method that calls Edge's public sandbox port-sharing endpoint with the requested access policy. Add request coverage to keep the public SDK path aligned with the Edge contract. Signed-off-by: Aaqa Ishtyaq <aaqaishtyaq@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sharePort(sandboxId, port, policy)to the public SDKPUTZeishPortAccessPolicyunionRoot cause
The SDK could create raw L4 ingress but could not change its access policy afterward. Public desktop users therefore had no SDK path to mark the TCP route public, leaving proxyd to reject unauthenticated browser traffic.
Validation
pnpm test --run src/public-api.test.ts(8 tests passed)pnpm typecheckNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.