Skip to content

fix: Auto-update package.json FileVersion when downloading new spec files - #196

Open
jtgreen86 wants to merge 8 commits into
splunk:masterfrom
jtgreen86:fix/auto-update-fileversion-setting
Open

fix: Auto-update package.json FileVersion when downloading new spec files#196
jtgreen86 wants to merge 8 commits into
splunk:masterfrom
jtgreen86:fix/auto-update-fileversion-setting

Conversation

@jtgreen86

@jtgreen86 jtgreen86 commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes an oversight in the spec file update workflow where new Splunk versions were downloaded to spec_files/ but not added to the splunk.spec.FileVersion setting in package.json. Users had to manually update the extension settings to use newly downloaded spec files.

Changes

  • Add updatePackageJsonVersions() function to scripts/update-spec-files.js that automatically:
    • Adds new versions to the splunk.spec.FileVersion enum
    • Sets the newest version as the default
  • Integrate the update into the existing workflow (Step 5)
  • Update PR report to include package.json changes
  • Add documentation to .github/copilot-instructions.md
  • Update package.json with missing versions: 9.3, 9.4, 10.0, 10.2, 10.4

Test Plan

  • Run node scripts/update-spec-files.js --check-only --verbose to verify script parses correctly
  • Verify package.json enum matches spec_files/ directories
  • Run npm test to ensure no regressions

Note: The functional-test macOS CI failure is a pre-existing issue on
master unrelated to this PR. VS Code 1.133.0 downloads successfully but the
Electron binary fails to spawn on the macos-latest ARM runner (ENOENT).
Unit tests pass on all platforms.

@jtgreen86
jtgreen86 requested a review from JasonConger August 18, 2026 12:55
@jtgreen86
jtgreen86 force-pushed the fix/auto-update-fileversion-setting branch from f1886b6 to a6dead2 Compare August 18, 2026 13:12
@jtgreen86
jtgreen86 force-pushed the fix/auto-update-fileversion-setting branch from a6dead2 to f55c58c Compare August 18, 2026 13:15
Comment thread .github/workflows/build-test.yaml Outdated
Comment thread .github/workflows/build-test.yaml Outdated
Comment thread .github/workflows/build-test.yaml Outdated
Comment thread .github/workflows/build-test.yaml Outdated

@JasonConger JasonConger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We updated the actions to use v7 recently. The MR uses v4 in build-test.yaml. Please test with v7. I don't anticipate any issues, but let's check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants