Prevent SQL source disclosure through path aliases - #1476
Merged
Merged
Conversation
81reap
approved these changes
Sep 22, 2026
Comment on lines
+231
to
+234
| // SQL Server ignores trailing spaces when comparing file-store paths. | ||
| // Windows can also alias trailing dots and NTFS stream names to the | ||
| // same file. Reject these spellings before routing can serve a SQL | ||
| // file as an ordinary static asset. |
Collaborator
There was a problem hiding this comment.
[nit] this shouldn't be a comment, it should be 3 different tests we can run in the CI. I see you have some of them already
lovasoa
force-pushed
the
codex/sql-source-disclosure
branch
from
September 24, 2026 21:35
5ecc246 to
496418b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mixed-case
.SQLrequests could resolve to a SQLPage source file on case-insensitive storage but be served as a static asset. SQLPage now routes every ASCII case variant of the.sqlextension through the SQL executor. Unprivileged paths also reject trailing-space aliases used by SQL Server and, on Windows, trailing-dot and NTFS stream aliases.Regression tests cover mixed-case routes and noncanonical file paths.
Validation:
cargo fmt --all;cargo clippy --all-targets --all-features -- -D warnings;cargo test --lib(222 passed).