Skip to content

fix(playwright) :: let the kernel choose the ports - #1490

Merged
lovasoa merged 1 commit into
mainfrom
81reap/playwright-ports
Sep 25, 2026
Merged

lovasoa merged 1 commit into
mainfrom
81reap/playwright-ports

Conversation

@81reap

@81reap 81reap commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

Before this was pinned to 8080 and 8081 which conflicted with any other program alerady on those ports.

Now each server binds to 127.0.0.1:0 and Playright's webServer.wait gets the port.

reuseExistingServer goes with the fixed ports, since there is no longer a known address for a stray server to answer on. The timeout rises to ten minutes because Playwright now starts the server itself, so that window has to cover a cold cargo run.


Stack created with GitHub Stacks CLI • Give Feedback 💬

@81reap
81reap added this pull request to stack #1492 September 24, 2026 05:42
@81reap
81reap force-pushed the 81reap/playwright-ports branch 2 times, most recently from 3a5609e to a97a6cb Compare September 24, 2026 13:23
@81reap
81reap force-pushed the 81reap/playwright-ports branch 2 times, most recently from 752fdf0 to e5b687b Compare September 24, 2026 13:57
@81reap
81reap force-pushed the 81reap/playwright-ports branch from e5b687b to 94b5af9 Compare September 24, 2026 15:17
@81reap
81reap force-pushed the 81reap/bound-port branch 2 times, most recently from 6a9bfec to ded5cb2 Compare September 24, 2026 15:17
@81reap
81reap force-pushed the 81reap/playwright-ports branch 2 times, most recently from 1848f7b to 39418ee Compare September 24, 2026 21:50
@81reap
81reap removed this pull request from stack #1492 September 24, 2026 21:50
@81reap
81reap force-pushed the 81reap/playwright-ports branch from 39418ee to 8790fe6 Compare September 24, 2026 22:00
@81reap
81reap added this pull request to stack #1497 September 25, 2026 04:19
@81reap
81reap force-pushed the 81reap/playwright-ports branch from 8790fe6 to 9bd8917 Compare September 25, 2026 04:19
@lovasoa
lovasoa removed this pull request from stack #1497 September 25, 2026 10:20
@lovasoa
lovasoa added this pull request to stack #1498 September 25, 2026 10:21
@81reap
81reap force-pushed the 81reap/playwright-ports branch from 9bd8917 to 8edcbd6 Compare September 25, 2026 13:33
@81reap
81reap removed this pull request from stack #1498 September 25, 2026 13:55
@81reap
81reap force-pushed the 81reap/playwright-ports branch from 8edcbd6 to f81f1da Compare September 25, 2026 13:55
Base automatically changed from 81reap/bound-port to main September 25, 2026 15:28
Before this was pinned to `8080` and `8081` which conflicted with any other program alerady on those ports.

Now each server binds to `127.0.0.1:0` and Playright's `webServer.wait` gets the port.

`reuseExistingServer` goes with the fixed ports, since there is no longer a known address for a stray server to answer on. The timeout rises to ten minutes because Playwright now starts the server itself, so that window has to cover a cold `cargo run`.
@81reap
81reap force-pushed the 81reap/playwright-ports branch from f81f1da to 478ecc6 Compare September 25, 2026 15:51
@81reap
81reap requested a review from lovasoa September 25, 2026 16:08
@lovasoa
lovasoa merged commit b91629d into main Sep 25, 2026
52 checks passed
@lovasoa
lovasoa deleted the 81reap/playwright-ports branch September 25, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants