Refactor HelperChild::parseConfig() to latest squid.conf parser API#2398
Draft
yadij wants to merge 2 commits into
Draft
Refactor HelperChild::parseConfig() to latest squid.conf parser API#2398yadij wants to merge 2 commits into
yadij wants to merge 2 commits into
Conversation
... to assist transition to new ConfigParser API for logic which is buried too deep or called from too many legacy code places to pass the parser in.
yadij
added
the
S-waiting-for-PR
Contributor
Author
|
Depends on PR #2397 |
rousskov
requested changes
Apr 2, 2026
Contributor
There was a problem hiding this comment.
Depends on PR #2397
I am blocking this PR because I have blocked its dependency, but current PR code also has bugs that will need to be addressed before this PR is merged. I plan to come back to this PR once the dependency issue is resolved and the backlog is dealt with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.