Ignifyr Test Extension - #302
Merged
Merged
Conversation
KeremHmd
commented
Jul 29, 2026
KeremHmd
commented
Contributor
- New E2E tests are added to test new behaviors built around enterprise/community separation and Kafka/REDcap streaming.
- A test-flow suite is built to provide options and configurations on how to run different kinds of tests/demo builds of Ignifyr and related tools. All options are documented to only allow the desired tests to be run during a development or a release build.
…to fit the new test classifications.
…tain environments
…+ test gaps - engine: registerBatchJob attached handleCompletedBatchJob with onComplete, which only schedules it, so a caller awaiting the raw job future raced the archiver. The one-shot batch CLI calls System.exit(0) right after that await, so with archiveMode archive/delete the processed inputs could be left in place. registerBatchJob now returns a Future chained with andThen, and MappingJobLauncher hands that back as MappingJobLaunch.Batch, so awaiting it means archiving is done. - test-flow: the ~6 MB jar listings made `echo "$VAR" | grep -q` invert under pipefail — grep exits at the first match and closes the pipe, echo dies of SIGPIPE, and the successful match evaluates as false. The enumeration guard therefore fired against a jar that `jar tf` lists fine and the whole jar-content section was silently skipped (passed: 19 instead of 41). Had it run, a marker actually present in the community jar would also have been reported as "excludes", so a real enterprise leak would have passed. Matched with bash substring tests. - build: Spark 3.5 reaches into JDK internals (StorageUtils -> sun.nio.ch.DirectBuffer), which JDK 17+ denies by default. spark-submit adds the module opens via JavaModuleOptions, but these suites run Spark embedded in the JVM scalatest-maven-plugin forks, so nothing adds them and every Spark-backed suite aborts. Added as argLine; harmless on the JDK 11 target thanks to -XX:+IgnoreUnrecognizedVMOptions.
The `pull_request` trigger was filtered to base branch main, so no CI ran on PRs opened
against the integration branches we actually target — including the current one. Dropped
the filter.
The long tier is now pull-request-only (plus workflow_dispatch): a push to main would just
repeat the tier its own PR already ran. Local runs stay opt-in via ${skipITs}, so a plain
`mvn install`/`verify` is short and Docker-free and `mvn verify -DskipITs=false` opts in.
Okanmercan99
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.