Resolved mismatch stubbings in A11yTest.java#36
Open
ARMS2025 wants to merge 1 commit intosridharbandi:masterfrom
Open
Resolved mismatch stubbings in A11yTest.java#36ARMS2025 wants to merge 1 commit intosridharbandi:masterfrom
ARMS2025 wants to merge 1 commit intosridharbandi:masterfrom
Conversation
Owner
|
@ARMS2025 Thanks for this PR. Apart from the tests, do you have faced any issues while using this library? |
Author
|
@sridharbandi No, I did not face any other issues while using the library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I analyzed the test doubles (mocks) in the test code of the project. In my analysis of the project, I observed that
In the test
testScriptUrlConfiguration:executeScriptmethod for thejavascriptExecutorobject:i) during test execution the method is actually called with argument
URL_CONFIGURATION_TEST_SCRIPT, but is not stubbed, resulting in a mismatch stubbing (as the argument is a lengthy string, we extracted it into a private static variable and used that variable in the stub creation).In the test
testExecute:executeScriptmethod for thejavascriptExecutorobject:i) during test execution the method is actually called with argument
EXECUTE_TEST_SCRIPT, but is not stubbed, resulting in a mismatch stubbing (as the argument is a lengthy string, we extracted it into a private static variable and used that variable in the stub creation).In general, a mismatched stubbing occurs when a method is stubbed with specific arguments in a test but later invoked with different arguments in the code. Mockito recommends addressing this type of issue (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org.mockito/org/mockito/exceptions/misusing/PotentialStubbingProblem.html).
I propose a solution below to resolve the mismatch stubbing. Happy to modify the pull request based on your feedback.