Skip to content

test: fix stale e2e scenario assertions from #138 and #140#142

Merged
joshua-temple merged 1 commit into
mainfrom
test/fix-stale-scenario-assertions
Jun 13, 2026
Merged

test: fix stale e2e scenario assertions from #138 and #140#142
joshua-temple merged 1 commit into
mainfrom
test/fix-stale-scenario-assertions

Conversation

@joshua-temple

Copy link
Copy Markdown
Collaborator

Problem

Three e2e scenario assertions went stale because generator output legitimately changed in #140 and #138. The generator behavior is correct; the assertions lagged behind.

Fix (test-only)

  • Updated the two uses: assertions to the fully-qualified path.
  • Converted the env-gates cdk deploy to an inline run: deploy, the job kind on which a job-level environment: key is actually valid, so the env-gate feature is genuinely exercised. The asserted 4-space, newline-anchored environment: ${{ github.event.inputs.environment || 'dev' }} now matches real output.

Verification

All new assertion strings were proven against real generator output (generate-workflow --orchestrate-only):

  • S12/S10: uses: ./.github/workflows/build.yaml present verbatim.
  • env-gates: environment: ${{ github.event.inputs.environment || 'dev' }} present at the 4-space job level.

go build ./... and cd e2e && go vet ./... are clean. The full act-based e2e suite was not run because local Docker is down.

… output

Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
@joshua-temple joshua-temple merged commit 5e980cb into main Jun 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant