test: fix stale e2e scenario assertions from #138 and #140#142
Merged
Conversation
… output Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three e2e scenario assertions went stale because generator output legitimately changed in #140 and #138. The generator behavior is correct; the assertions lagged behind.
12-inline-run-callback.yamland10-inline-job-attributes.yamlasserteduses: ./build.yaml, but fix: normalize local callback workflow paths to .github/workflows #140 made the generator emit the fully-qualifieduses: ./.github/workflows/build.yaml.orchestrate/env-gates.yamlasserted a job-levelenvironment:key on a reusable-workflow (uses:) deploy. Per Generator emits 'environment:' on reusable-workflow (uses:) deploy jobs, which GitHub rejects #137/fix: omit job-level environment on reusable-workflow deploy jobs #138 the generator now correctly omits the job-level key on auses:caller job (GitHub Actions forbids it there).Fix (test-only)
uses:assertions to the fully-qualified path.cdkdeploy to an inlinerun:deploy, the job kind on which a job-levelenvironment:key is actually valid, so the env-gate feature is genuinely exercised. The asserted 4-space, newline-anchoredenvironment: ${{ github.event.inputs.environment || 'dev' }}now matches real output.Verification
All new assertion strings were proven against real generator output (
generate-workflow --orchestrate-only):uses: ./.github/workflows/build.yamlpresent verbatim.environment: ${{ github.event.inputs.environment || 'dev' }}present at the 4-space job level.go build ./...andcd e2e && go vet ./...are clean. The full act-based e2e suite was not run because local Docker is down.