ci: validate-then-tag gate chain with fleet on published artifact#212
Merged
Conversation
Run Tests & Lint and Integration on push to main and on pull_request so the trunk badges render and PRs are gated, dropping their tag triggers. Add a concurrency group and paths filter to Integration so a superseded or docs-only run does not burn a 27min testcontainers slot. Re-point Fleet E2E from the Integration workflow_run to the Release workflow_run so the fleet validates the published artifact: Release runs GoReleaser on every rc tag, so a successful Release run means the binary the suites install is on the releases page. The rc-tag gate and the no-op-on-filtered-completion behavior are unchanged. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CI gate ladder did not validate trunk or PRs the way the badges imply, and Fleet E2E validated a pre-tag build rather than the published artifact:
Tests & Lint(validate.yaml) only ran via orchestrate'sworkflow_calland on tag pushes, so its?branch=mainbadge showed no status (its only standalone run was on a tag ref).Integration (act + gitea)(e2e.yaml) only ran on tags / merge_group, so it never gated a PR or populated a main badge.Fleet E2Efanned out on the Integrationworkflow_run, validating the act+gitea build, not the binary actually published to the releases page.Fix
push: { branches: [main] }andpull_request; droppush: { tags: [v*] }; keepworkflow_call(orchestrate depends on it) andworkflow_dispatch.push: { branches: [main] }andpull_request(both with the samecmd|e2e|go.mod|go.sum|internalpaths filter that orchestrate already uses); droppush: { tags: [v*] }; keepmerge_groupandworkflow_dispatch. Addconcurrency: { group: integration-${{ github.ref }}, cancel-in-progress: true }so a superseded run on the same ref is cancelled rather than burning a second ~27min testcontainers slot.workflow_runtrigger from "Integration (act + gitea)" to "Release". Release runs GoReleaser on every rc tag push, so a successful Release run is the dependable signal that the published artifact exists. We key off the Release workflow_run (not therelease:event) because promote-driven API releases do not reliably emitrelease: published(release.yaml feat: optional PR plan-preview workflow #86). The resolve job already derives the rc version fromworkflow_run.head_branch(with ahead_shatag-lookup fallback); the rc-tag gate (startsWith(.,'v') && contains(.,'-rc.')) and the no-op-on-filtered-completion behavior are unchanged.Resulting chain
push/PR -> Tests & Lint + Integration gate -> rc tag (orchestrate, post its internal validate + build-cli) -> Release publishes the binary -> Fleet E2E validates the published artifact.
Verification
Tests & Lintbadge already carried the correctalttext (no change needed).