fix: drop toolchain pin from state go.mod (unblocks v1.0.0 release)#166
Merged
Conversation
… floor Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this change does
Removes the
toolchain go1.26.4directive fromstate/go.mod. Thestatemodule is standard-library-only and does not call the crypto/x509 / net/textproto advisories, so it never needed the pinned toolchain — but the directive forced a go1.26.4 toolchain, which breaks buildingstateon its declaredgo 1.25floor underGOTOOLCHAIN=local(as the release validation gate runs). The 1.25 matrix legs failed for this reason; the 1.26.4 legs passed.Why
statesupports Go 1.25; the toolchain pin contradicted that and blocked the v1.0.0 release validation.govulncheckstays clean forstateregardless of toolchain (it does not call the affected stdlib paths).Checklist