chore: pin gen and state/expr to state v1.0.0 for release#168
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins
genandstate/exprto the publishedstatev1.0.0 so both modules resolve for outside consumers. Drops the local workspacereplace github.com/stablekernel/crucible/state => ...from each go.mod and bumps the require from the workspace placeholder tov1.0.0; go.sum now carries the proxy hashes. Local dev still resolvesstatelocally through theuseblock ingo.work.Also drops the unneeded
toolchain go1.26.4pin from both modules. govulncheck reports no called vulnerabilities in either, so they build on theirgo 1.25floor; keeping the pin would fail the release gate's 1.25.11 leg underGOTOOLCHAIN=local, the same reason it was removed fromstate.Verified consumer-style (
GOWORK=off) with no local replace:genbuilds and 24 tests pass;state/exprbuilds and 96 tests pass, both resolvingstate@v1.0.0from the proxy. Workspace builds still pass for both.