test: raise cmd/crucible coverage above the release threshold#170
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cmd/cruciblemodule fell below the release coverage gate (76.2% vs the 80% threshold inrelease.yml), which blocks tagging a release.This adds focused tests against the existing
runX(args, stdout, stderr) intseams covering the previously-uncovered CLI paths: every subcommand's load-error and quench-error branch, flag-parse and wrong-arg-count errors, eject's default-package and write-failure paths, diff's read/decode errors, the help variants, the--arg terminator, and a compound+parallel IR fixture that drives the deepwalkState/walkTransitionbranches (children, regions, invoke, entry/exit/done actions, assigns, composite guard expr).Total coverage rises from 76.2% to 96.4%. No production code or
go.modchanges; dep pins (state v1.0.0, gen v0.1.0) are untouched.