Test platform branches on the platform they apply to - #1282
Merged
Merged
Conversation
The toolchain and WSL tests mocked os_is_windows() and os_is_wsl() to force a platform branch on every OS. Most of those mocks sat under a skip and did nothing; the rest compared strings that mocked helpers produced. Each test now runs the branch its platform takes, and the Windows and WSL CI jobs cover theirs. The mocked WSL output_dir test is removed because the two real-WSL tests after it check the same behaviour end to end.
jgabry
marked this pull request as ready for review
September 22, 2026 18:59
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1282 +/- ##
==========================================
- Coverage 92.40% 92.08% -0.32%
==========================================
Files 15 15
Lines 6570 6570
==========================================
- Hits 6071 6050 -21
- Misses 499 520 +21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
The toolchain and WSL tests mocked
os_is_windows()andos_is_wsl()to force a platform branch on every OS. Most of those mocks sat under askip_if(!os_is_windows())and did nothing; the rest made the tests compare strings that mocked helpers produced. Each test now runs the branch its platform really takes, and the Windows and WSL CI jobs cover theirs.Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah Gabry
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: