Drop pre-2.37 CmdStan support for v1.0 - #1290
Merged
Merged
Conversation
v1.0 raised the floor to 2.35, which never shipped, so this moves the same floor to 2.37 and edits the same NEWS bullet. CmdStan 2.36 runs HMC for a model with no parameters instead of switching to fixed_param on its own, so the CSV always has the sampler diagnostics we read. That retires the version gate in $sample() that demanded fixed_param = TRUE below 2.36, the roxygen sentence about it, and the two test helpers whose only job was faking a 2.35 version for that gate's test. 2.37 is the first CmdStan that takes one output file per chain on a single num_chains run, which #534 will need, and we expect to do that soon after v1.0 if not in it. man/model-method-format.Rd picks up the bare "stanc" from #1289, which edited the roxygen without regenerating this file. Part of #1258.
Three tests in test-install.R request CmdStan 2.35.0, 2.35.5 or 2.36.0 to exercise the "installation already exists" warning, the failed download errors and the make/local prompt. Now that the floor is 2.37.0, the version check rejects each request before the code under test runs, which failed every CI job on the previous commit. The tests request 2.37.0 and 2.37.5 instead; 2.37.5 is not a release, so the download still fails as the test expects. Part of #1258.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1290 +/- ##
==========================================
+ Coverage 92.08% 93.04% +0.96%
==========================================
Files 15 19 +4
Lines 6570 7309 +739
==========================================
+ Hits 6050 6801 +751
+ Misses 520 508 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
Why 2.37:
$sample()that requiredfixed_param = TRUEbelow 2.36, the roxygen sentence about it, and the two test helpers that existed only to fake a 2.35 version for that gate's test. Everything else aboutfixed_paramstays, since it's still the way to hold parameters fixed or to run a model with no parameters without HMC.num_chainsrun, which [FR] Use new num_chains arg in cmdstan for hmc, fixed params, and generated quantities #534 needs, and we expect to do that soon after v1.0 if not in it.Part of #1258.
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah Gabry
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: