Conversation
RemotePeerActivity improvements: - Added node alias display prominently at top - Collapsible "Node Details" section with node key, IP, features - Styled "Share" button with bold/underlined text - Reordered channel buttons (Normal > Hosted SAT > Fiat USD > Fiat EUR) - Feature tags in 2-column grid layout ChanActivity improvements: - Changed from horizontal chips to vertical buttons - Fixed double-click scanner issue with onRequestPermissionsResult handler - Added frag_chan_footer.xml layout Minor fixes: - Fixed typo in colors.xml (extra > on cardFiatUsd) - Added colorGreen color
|
@0orion do you have an apk build for this PR? |
Author
Yes, there's an apk build for it. I'm just seeing this now. |
Author
Here: https://github.com/0orion/valet/releases/tag/Valet_Bitcoin |
Author
OLD
NEW
|
Author
OLD
NEW
|
here you introduced friction when opening new channel. Please revert. |
evd0kim
reviewed
Apr 14, 2026
| val hview = new HostedViewHolder(card).fill(chan, hc) | ||
| hview.queryRates(chan) | ||
| // Only query rates for Fiat channels, not standard Hosted Channels | ||
| if (!hc.isStandardHostedChannel) hview.queryRates(chan) |
| serverRateText.setText(fiatOrNothing(serverRate, cardIn,s"${ticker.tag}/BTC").html) | ||
| // rateText.setText(fiatOrNothing(rate, cardIn,s"${ticker.tag}/BTC").html) | ||
| fiatText.setText(fiatOrNothing(hc.fiatValue, cardIn, ticker.tag).html) | ||
| if (isFiatChannel) { |
| import fr.acinq.eclair.transactions.Scripts | ||
| import fr.acinq.eclair.wire._ | ||
| import immortan.Ticker.{EUR_TICKER, USD_TICKER} | ||
| import immortan.Ticker.{EUR_TICKER, SAT_TICKER, USD_TICKER} |
There was a problem hiding this comment.
Here too. Please check your changes because they concern not just UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Improved user experience when connecting to remote peers and managing channels.
It also optimized the camera pop up for QR scan (Initially had a serious lag that required double clicking on the "Scan Node QR" button before camera pops up)
@evd0kim