Skip to content

scripts,workspace: bump cargo-deny to 0.20.2 so the check runs - #15107

Open
avi-starkware wants to merge 1 commit into
avi/deps/00a-mark-unpublished-cratesfrom
avi/deps/00-cargo-deny-config
Open

avi-starkware wants to merge 1 commit into
avi/deps/00a-mark-unpublished-cratesfrom
avi/deps/00-cargo-deny-config

Conversation

@avi-starkware

@avi-starkware avi-starkware commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

The CI cargo-deny job has never evaluated a check: cargo-deny 0.16.2 (pinned in scripts/install_cargo_tools.sh) rejects the allow-workspace key in deny.toml and exits while deserializing the config, and continue-on-error: true hides the exit code. Even with that key removed, 0.16.2 aborts on advisories carrying CVSS 4.0 scores.

  • Pin cargo-deny 0.20.2 (latest; needs Rust ≥1.88, toolchain is 1.96). It accepts the allow-workspace key, so the template deny.toml stays as is apart from the addition below.
  • allow-wildcard-paths = true under [bans]. It only exempts dev-dependency path deps and publish = false crates, which is why workspace,scripts: mark workspace-only crates publish = false and enforce it when publishing #15115 below marks the workspace-only crates publish = false first. With both, bans reports exactly one wildcard: starknet_proof_verifier is publishable but depends on the git dependency privacy-circuit-verify-v2 with no crates.io version — a real finding, deliberately left visible.

Verified: cargo deny check parses and runs all four checks (advisories FAILED, bans FAILED, licenses FAILED, sources ok at this point; bans is down to the single finding above, and the following PRs address advisories and licenses); taplo fmt --check clean.

🤖 Generated with Claude Code

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@avi-starkware
avi-starkware added this pull request to stack #15113 September 10, 2026 13:06
@avi-starkware
avi-starkware force-pushed the avi/deps/00-cargo-deny-config branch from 89c9d57 to 2be9afd Compare September 14, 2026 09:51
@github-actions

Copy link
Copy Markdown

Artifacts upload workflows:

@avi-starkware
avi-starkware removed this pull request from stack #15113 September 14, 2026 09:54
@avi-starkware
avi-starkware changed the base branch from main-v0.14.4 to avi/deps/00a-mark-unpublished-crates September 14, 2026 09:54
@avi-starkware
avi-starkware added this pull request to stack #15116 September 14, 2026 09:55
@avi-starkware
avi-starkware force-pushed the avi/deps/00-cargo-deny-config branch from 2be9afd to f733c5e Compare September 14, 2026 10:15
@avi-starkware avi-starkware changed the title scripts,workspace: bump cargo-deny to 0.20.2 and fix deny.toml so the check runs scripts,workspace: bump cargo-deny to 0.20.2 so the check runs Sep 14, 2026
The CI cargo-deny step never reached a single check: version 0.16.2 rejects the
`allow-workspace` key in deny.toml and exits while deserializing the config, and even
with that key removed it aborts on advisories that carry CVSS 4.0 scores. Bumping the
pinned version to 0.20.2, which accepts the key, fixes both failures. Enabling
`allow-wildcard-paths` exempts path dependencies that carry no version requirement from the
deny-level wildcard lint, for dev-dependencies and for the crates marked `publish = false`.
Path dependencies of publishable crates are still reported; starknet_proof_verifier remains
the one finding.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@avi-starkware
avi-starkware force-pushed the avi/deps/00-cargo-deny-config branch from f733c5e to e3b3021 Compare September 14, 2026 10:37
@avi-starkware
avi-starkware marked this pull request as ready for review September 14, 2026 11:15
@cursor

cursor Bot commented Sep 14, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Tooling and deny.toml configuration only; no application runtime behavior changes, though CI may now report real advisories/licenses/bans findings that were previously skipped.

Overview
Fixes CI cargo deny check, which previously failed during config parse on the pinned 0.16.2 tool (and could be masked by continue-on-error). The install script now pins cargo-deny 0.20.2, which supports the existing deny.toml shape and current advisory metadata.

Under [bans], allow-wildcard-paths = true is added so workspace path dependencies without version requirements are not flagged as wildcard violations when they are dev-dependencies or publish = false crates; publishable crates with unversioned path/git deps still surface in the bans check.

Reviewed by Cursor Bugbot for commit e3b3021. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants