scripts,workspace: bump cargo-deny to 0.20.2 so the check runs - #15107
avi-starkware wants to merge 1 commit into
Conversation
89c9d57 to
2be9afd
Compare
|
Artifacts upload workflows: |
2be9afd to
f733c5e
Compare
The CI cargo-deny step never reached a single check: version 0.16.2 rejects the `allow-workspace` key in deny.toml and exits while deserializing the config, and even with that key removed it aborts on advisories that carry CVSS 4.0 scores. Bumping the pinned version to 0.20.2, which accepts the key, fixes both failures. Enabling `allow-wildcard-paths` exempts path dependencies that carry no version requirement from the deny-level wildcard lint, for dev-dependencies and for the crates marked `publish = false`. Path dependencies of publishable crates are still reported; starknet_proof_verifier remains the one finding. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
f733c5e to
e3b3021
Compare
PR SummaryLow Risk Overview Under Reviewed by Cursor Bugbot for commit e3b3021. Bugbot is set up for automated code reviews on this repo. Configure here. |
The CI
cargo-denyjob has never evaluated a check: cargo-deny 0.16.2 (pinned inscripts/install_cargo_tools.sh) rejects theallow-workspacekey indeny.tomland exits while deserializing the config, andcontinue-on-error: truehides the exit code. Even with that key removed, 0.16.2 aborts on advisories carrying CVSS 4.0 scores.allow-workspacekey, so the templatedeny.tomlstays as is apart from the addition below.allow-wildcard-paths = trueunder[bans]. It only exempts dev-dependency path deps andpublish = falsecrates, which is why workspace,scripts: mark workspace-only crates publish = false and enforce it when publishing #15115 below marks the workspace-only cratespublish = falsefirst. With both,bansreports exactly one wildcard:starknet_proof_verifieris publishable but depends on the git dependencyprivacy-circuit-verify-v2with no crates.io version — a real finding, deliberately left visible.Verified:
cargo deny checkparses and runs all four checks (advisories FAILED, bans FAILED, licenses FAILED, sources okat this point;bansis down to the single finding above, and the following PRs address advisories and licenses);taplo fmt --checkclean.🤖 Generated with Claude Code