Skip to content

starknet_transaction_prover: capture prover panics through the observability hook - #15125

Closed
avi-starkware wants to merge 1 commit into
avi/prover/mod-builtin-circuit-entry-pointsfrom
avi/prover/unsupported-mod-builtins
Closed

avi-starkware wants to merge 1 commit into
avi/prover/mod-builtin-circuit-entry-pointsfrom
avi/prover/unsupported-mod-builtins

Conversation

@avi-starkware

@avi-starkware avi-starkware commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

Capture prover panics through the service's existing observability hook. This is the first half of the unsupported-mod-builtin work; it does not classify builtins or introduce a new RPC error code.

  • Record panic locations on the panicking thread while preserving structured logging, payload redaction, and backtraces.
  • Catch unwinds at the synchronous prover boundary and return ProverPanic with the message and available location.
  • Clear recorded locations before and after each call to avoid stale attribution.
  • Keep panics and returned prover errors mapped to JSON-RPC -32603. The spec pin is unchanged.
  • Test payload forms, exact locations, stale and nested captures, logging, and RPC mapping.

Stacked on #15124. #15131 adds unsupported-builtin classification, spec error 1002, and real-proving regressions.

Verification

Run independently on this layer, using its own pinned spec:

  • Proving-enabled library suite: 148 passed, 6 ignored.
  • Non-proving library suite: 140 passed, 5 ignored; one doc test passed.
  • Clippy with -D warnings passed in both configurations. Formatting passed.
cargo +nightly-2026-01-15 test --locked -p starknet_transaction_prover --features stwo_proving --release --lib --quiet
cargo +nightly-2026-01-15 clippy --locked --release -p starknet_transaction_prover --features stwo_proving --all-targets -- -D warnings
cargo test --locked -p starknet_transaction_prover --quiet
cargo clippy --locked -p starknet_transaction_prover --all-targets -- -D warnings

@avi-starkware
avi-starkware added this pull request to stack #15126 September 15, 2026 08:50
@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@avi-starkware
avi-starkware force-pushed the avi/prover/mod-builtin-circuit-entry-points branch from bf12ae8 to 536ac89 Compare September 15, 2026 13:45
@avi-starkware
avi-starkware force-pushed the avi/prover/unsupported-mod-builtins branch from 02154f5 to 8d015d9 Compare September 15, 2026 13:45
@avi-starkware
avi-starkware force-pushed the avi/prover/mod-builtin-circuit-entry-points branch from 536ac89 to 371661a Compare September 15, 2026 19:40
@avi-starkware
avi-starkware force-pushed the avi/prover/unsupported-mod-builtins branch from cd1e633 to 22b7a90 Compare September 15, 2026 19:40
@avi-starkware
avi-starkware removed this pull request from stack #15126 September 15, 2026 19:41
@avi-starkware
avi-starkware added this pull request to stack #15130 September 15, 2026 19:42
@avi-starkware
avi-starkware force-pushed the avi/prover/unsupported-mod-builtins branch from 22b7a90 to d2d5a92 Compare September 15, 2026 20:00
@avi-starkware avi-starkware changed the title starknet_transaction_prover,starknet_os_flow_tests,ci: pin and classify unsupported mod builtins starknet_transaction_prover: capture prover panics through the observability hook Sep 15, 2026
@avi-starkware
avi-starkware removed this pull request from stack #15130 September 15, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants