docs(transcript): scope previews and publication explicitly - #39
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed September 5, 2026, 3:59 PM ET / 19:59 UTC. ClawSweeper reviewWhat this changesThe PR simplifies the agent-transcript skill, separates preview permission from publication authorization, warns against rerendering approved content, and adds a changelog entry. Merge readiness✅ Ready for maintainer review The instructions accurately address the helper’s rerendering behavior, and no actionable patch defect was found. The clarification remains useful relative to the fetched main branch; owner-authored work and this repository’s conservative cleanup profile also preclude automatic closure. Priority: P3 Review scores
Verification
How this fits togetherThe agent-transcript skill guides agents from local session logs to sanitized excerpts for GitHub issue and PR bodies. Its instructions control which content is previewed and when that content may be published. flowchart TD
A[Explicit transcript request] --> B[Local session discovery]
B --> C[Render sanitized Markdown]
C --> D[Trim and inspect content]
D --> E[Local preview]
D --> F{Publication authorized?}
F -->|Yes| G[Insert inspected transcript]
F -->|No| E
Before mergeNone. Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Keep one explicit workflow that previews scoped content and publishes that same inspected content only under destination-specific authorization. Do we have a high-confidence way to reproduce the issue? Not applicable as a runtime bug reproduction: this patch changes instructions, and source inspection confirms the documented rerendering behavior. Is this the best way to solve the issue? Yes. Clarifying the artifact and publication boundaries in the existing skill addresses the ambiguity without introducing another helper or changing its supported interface. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against d2790cf56f08. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Summary
Make the transcript skill explicit-request-only and require task scoping before any preview or publication. A transcript-generation or preview request, and ordinary PR editing permission, do not authorize publishing the transcript. Existing authorization specifically covering transcript publication remains sufficient.
The helper's preview/append modes rerender the session, so the instructions now prevent them from silently replacing an inspected trimmed artifact. Helper code is unchanged.
Validation
Frontmatter and whitespace checks passed. The actual helper modes were inspected, the helper is byte-unchanged, and the same publication contract is synchronized into the OpenClaw consumer. Independent Codex review passed with no actionable P0–P2 findings. The repository commit hook validated 55 skills; exact-head CI is checked before landing.