Skip to content

Fix quickstart configure_factory to discover non-Go repos#56

Merged
stempeck merged 1 commit into
mainfrom
issues/55
Jun 9, 2026
Merged

Fix quickstart configure_factory to discover non-Go repos#56
stempeck merged 1 commit into
mainfrom
issues/55

Conversation

@stempeck

@stempeck stempeck commented Jun 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove the redundant && [ -f "$d/go.mod" ] clause from configure_factory() in quickstart.sh so workspace discovery selects any cloned repo by its .git directory alone, making it tech-stack-agnostic
  • Update the discovery comment and error message to no longer reference go.mod
  • Add TestQuickstartConfigureFactoryDiscovery tests locking in stack-agnostic discovery, the .git filter, the updated error message, and the preserved install_af source go.mod check

Problem

configure_factory() required both .git and go.mod to identify the target repo under $WORKSPACE_DIR. The go.mod check provided zero disambiguation (the only competing directory, aftmp, has no .git and was already excluded), but broke setup for any non-Go customer repo.

Fix

Minimal clause removal: drop && [ -f "$d/go.mod" ] from the discovery loop, retain the [ -d "$d/.git" ] filter. The install_af AF-source go.mod check is untouched.

Fixes #55

Test plan

  • TestQuickstartConfigureFactoryDiscovery verifies configure_factory has no go.mod reference
  • TestQuickstartConfigureFactoryDiscovery verifies .git filter is preserved
  • TestQuickstartConfigureFactoryDiscovery verifies error message says "No git repository" without go.mod
  • TestQuickstartConfigureFactoryDiscovery verifies install_af still checks $SCRIPT_DIR/go.mod for agentfactory

🤖 Generated with Claude Code

…y in quickstart.sh so non-Go customer repos are found by .git alone, update the error message accordingly, and add tests locking in stack-agnostic discovery while preserving the separate install_af source check.
@stempeck stempeck merged commit 6fa9c89 into main Jun 9, 2026
6 checks passed
@stempeck stempeck deleted the issues/55 branch June 9, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: drop redundant go.mod clause from quickstart.sh configure_factory repo discovery

1 participant