Conversation
…y in quickstart.sh so non-Go customer repos are found by .git alone, update the error message accordingly, and add tests locking in stack-agnostic discovery while preserving the separate install_af source check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
&& [ -f "$d/go.mod" ]clause fromconfigure_factory()inquickstart.shso workspace discovery selects any cloned repo by its.gitdirectory alone, making it tech-stack-agnosticgo.modTestQuickstartConfigureFactoryDiscoverytests locking in stack-agnostic discovery, the.gitfilter, the updated error message, and the preservedinstall_afsourcego.modcheckProblem
configure_factory()required both.gitandgo.modto identify the target repo under$WORKSPACE_DIR. Thego.modcheck provided zero disambiguation (the only competing directory,aftmp, has no.gitand was already excluded), but broke setup for any non-Go customer repo.Fix
Minimal clause removal: drop
&& [ -f "$d/go.mod" ]from the discovery loop, retain the[ -d "$d/.git" ]filter. Theinstall_afAF-sourcego.modcheck is untouched.Fixes #55
Test plan
TestQuickstartConfigureFactoryDiscoveryverifiesconfigure_factoryhas nogo.modreferenceTestQuickstartConfigureFactoryDiscoveryverifies.gitfilter is preservedTestQuickstartConfigureFactoryDiscoveryverifies error message says "No git repository" withoutgo.modTestQuickstartConfigureFactoryDiscoveryverifiesinstall_afstill checks$SCRIPT_DIR/go.modfor agentfactory🤖 Generated with Claude Code