Conversation
…, quality/fidelity gate application, dispatcher auto-start, and scoped watchdog; make worktree failures best-effort, tear down dispatcher on bare af down, centralize escalation target, and fix git exclude pattern for .gitignore re-include compatibility. Fixes #57.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.agentfactory/startup.jsonconfig that drives bareaf up: agent subset selection (null=all,[]=none, list=subset),quality/fidelitygate application,start_dispatchauto-start, andwatchdog_agentsscoping — positionalaf up <names>bypasses all of it (C-4 backward compat)af upaf down(symmetric with startup)escalation.go(escalationTargetconst +escalationTargets()) replacing hardcoded"supervisor"strings in watchdog and compact_handoff.agentfactory/(directory-form) to.agentfactory/*(contents-form) so committed.gitignorere-includes for agent definitions work--agentsflag to watchdog, extractlaunchDispatchSession()andstartDispatch()lenient path, extractapplyFidelityGate()/applyGate()for af-up reusemax_worktrees, and omission warning when a startup subset drops a known mail/notify/escalation sinkstartup.jsoninaf install --initwith opinionated defaultsFixes #57
Test plan
TestLoadStartupConfig_*(7 cases): absent file defaults, bad gate value, full round-trip, empty agents slice, empty object, malformed JSON, scaffold loadsTestRunUp_NoStartupConfig_AllStart_BareWatchdog: no startup.json starts all agents with bare watchdogTestRunUp_ConfiguredSubset_GateDispatchScope: subset + quality gate + dispatch + watchdog scope all applyTestRunUp_PositionalArgsWin:af up <names>ignores startup.jsonTestRunUp_EmptyAgents_LoudNotice:agents:[]starts zero agents with loud noticeTestRunUp_SubsetExceedsMaxWorktrees_Warns: pre-flight warning before start loopTestRunUp_OmitsSupervisorEscalationTarget_Warns: omission warning driven byescalationTargets()TestRunUp_FidelityOffFromSubdir_GuardChecksRoot: active-formula guard checks resolved root, not cwdTestRunUp_FidelityOffNoActiveFormula_Applies: fidelity off applies when no formula activeTestRunUp_DispatchLaunchFailure_WarnsAndFailsExit: dispatch failure is best-effort (warn + allOK=false)TestRunUp_WatchdogAgentsUnknownEntry_Warns: unknown watchdog_agents entry warns at af-up timeTestRunUp_WorktreeCapHit_SkipsAndContinues: worktree failure warn+skip+continue (not abort)TestStartDispatch_*(8 cases): already-running benign, absent config skip, empty default skip, malformed JSON warns, invalid type warns, IO error warns, friendly skip pinned, valid config launchesTestDown_StopsDispatchSession/TestDown_NoDispatchSession_Silent/TestDown_SingleAgent_LeavesDispatch: dispatch teardown symmetryTestApplyFidelityGate_*/TestApplyGate_*(7 cases): gate extraction and guard behaviorTestWatchdog_PollScopeFiltersAgents/TestBuildWatchdogScope: multi-agent scope filteringTestEnsureGitExclude_DoesNotDefeatGitignoreReincludes: live git check-ignore verificationTestEscalationTargets_IncludesSupervisor: centralized escalation constant sanity🤖 Generated with Claude Code