Extract reusable navigation and configurable menu templates - #1
Merged
Merged
Conversation
CrazyBoy49z
force-pushed
the
feature/extract-navigation
branch
from
September 23, 2026 09:06
6884300 to
936188b
Compare
CrazyBoy49z
marked this pull request as ready for review
September 23, 2026 09:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the Laravel package skeleton with a standalone navigation package. Move the menu manager, ordering registry, facade and Blade templates from lazy-admin. Keep request-scoped manager and singleton module registry; allow overriding the menu, item and label views via standard Laravel package view overrides,
Menu::useView()or a per-renderMenu::render($view)argument. No menu config file is needed. Include independent menu tests and Git-only installation instructions.Related lazy-admin draft PR #35 uses this package through a Composer VCS dependency and keeps its old Menu, MenuManager, MenuRegistry and facade imports as compatibility shims. The dependency points to
dev-feature/extract-navigationuntil this branch is merged; switch todev-mainbefore landing the admin PR. Latest push: PHPStan, styling and all 24/24 GitHub Actions test matrix jobs passed, including config-free template selection and native Blade partial override tests. Private GitHub access is required for Composer in the dependent lazy-admin CI.Follow-up:
Menu::register(..., group: 'admin.menu.blog')inserts a translated section heading, andaddItem('admin.blog.index')orcreateMenu('admin.blog.index')use the route name as their translation key when no label is supplied. Explicit labels and manual group pushes still work. Missingbefore/afteranchors are ignored, and registration invalidates the order cache when an optional module appears. Latest CI: PHPStan passes and all 24/24 test matrix jobs succeed.