Move virtual camera shutdown to subscription in service.#5937
Draft
michelinewu wants to merge 1 commit into
Draft
Move virtual camera shutdown to subscription in service.#5937michelinewu wants to merge 1 commit into
michelinewu wants to merge 1 commit into
Conversation
BundleMonFiles updated (1)
Unchanged files (3)
Total files change +28B 0% Final result: ✅ View report in BundleMon website ➡️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary VirtualWebcamService initialization during app shutdown
Issues
shutdownHandler()inAppServiceexplicitly calledstop()onVirtualWebcamService. Because services load lazily, this caused the service to be instantiated at shutdown time, even when the user never used the virtual camera during the session, triggering unnecessary OBS calls (Windows (OBS_service_isVirtualCamPluginInstalled) and Mac (OBS_service_createVirtualCam)) on every app close.Fixes
VirtualWebcamService.init()now subscribes toAppService.shutdownStarted, aSubjectthat fires early in the shutdown sequence before OBS is torn down. SinceSubject.next()andstop()are both synchronous, the virtual cam is stopped inline before shutdown continues. The subscription only exists if the service was actually instantiated during the session, so users who never use virtual camera incur no cost.AppServiceno longer imports or referencesVirtualWebcamService.File(s) changed:
desktop/app/services/app/app.tsdesktop/app/services/virtual-webcam.tsPerformance Implications
VirtualWebcamServiceinstantiated +init()run + OBS API called at shutdownstop()called fromshutdownHandlerstop()called viashutdownStartedsubscription