macOS gold via MoltenVK (real Apple GPU path) + some CompareGold improvements#3198
Merged
Conversation
…ket, surface in CompareGold
…platform list, grey-out + auto-select platforms by source coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
macOS gold via MoltenVK (real Apple GPU path)
Switches macOS test rendering from Lavapipe (CPU) to bundled MoltenVK, Apple's actual Vulkan-on-Metal path.
Captured new golds under per-GPU-family buckets
Apple M4.MoltenVK loader is pinned via
VK_DRIVER_FILESfrom aModuleInitializer, so brew'smolten-vkis no longer needed (temporary until KhronosGroup/MoltenVK#2731 is fixed)Lavapipe stays available on macOS via
STRIDE_TESTS_GPU=0.CompareGold tool changes
*.metadata.json) — captures OS / CPU / GPU / driver name + version / Vulkan API version, sourced fromVkPhysicalDeviceDriverProperties(Vulkan) andIDXGIAdapter(D3D). Main sidecar renamed.json→.results.jsonso the two never collide.Apple M4,Lavapipe,WARP, etc., derived from driver identity instead of the previousSW_RENDERINGenv hack. On Apple paravirtualized GPUs (macOS VMs / GH Actions), falls back to the CPU brand string for a stable family bucket.run_number(#22) in source labels; PNG-less platforms greyed out; auto-select first source-bearing platform on add/remove;--port/--lanflags.Types of changes
Checklist