Ran ruff check --fix with ruff 0.16.0 - #306
Draft
max-models wants to merge 4 commits into
Draft
Conversation
max-models
marked this pull request as draft
July 30, 2026 06:40
Member
Author
|
Apparently it wasn't safe https://github.com/struphy-hub/struphy/actions/runs/30520367676/job/90799156512?pr=306 |
Member
Author
|
The issue is that ruff changed the imports in the pyccelized kernels which changes the way our Therefore, in order to finish this PR, we first have to move to the build in makefile system in recent versions of pyccel and use that instead of our own makefile. See #18 for example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #290
This PR just contains automatic fixes by ruff 0.16.0, so there should not be any risks.
Next, we should also take care of the non-automatic fixes so we comply with all the ruff 0.16.0 rules.
Note that this formatting changes a few smart cases such as
before:
after: