Fix broken link check workflow - #382
Merged
Merged
Conversation
The markdown-link-check step's custom config (ignore patterns for
{{...}} Liquid syntax, /images/* paths, and expected 403/202/999
statuses) was never being applied. The generate-config step wrote it
to $RUNNER_TEMP, but that step's action runs in a Docker container
where $RUNNER_TEMP is mounted at a different path, so the config file
was never found and every internal link and third-party 403 got
reported as dead. Write the generated config into $GITHUB_WORKSPACE
instead, which mounts 1:1 into the container, and reference it as a
workspace-relative path.
Also drop the Slack notification step. It posted to a webhook that no
longer exists (Slack returned 404/no_active_hooks on every run), and
Slack is no longer used for this notification.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The generated replacementPatterns embedded $GITHUB_WORKSPACE, which is the runner's host-side path (e.g. /home/runner/work/...). The check itself runs inside the markdown-link-check Docker container, where the workspace is mounted at the fixed path /github/workspace instead, so every internal link resolved to a path that doesn't exist in the container even though the file is really there. Hardcode /github/workspace since that mount point is a fixed property of this action, not the runner. Also add 418 to aliveStatusCodes. IEEE Xplore returns it to automated clients as an anti-bot response, the same way other publishers already allow-listed here return 403; it doesn't mean the paper is gone. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
notthetup
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled broken-link-check job has been failing on every run, reporting hundreds of false positives and never producing a usable signal. Root causes were two Docker container path mismatches:
Also removed the Slack notification step (webhook no longer active, Slack unused) and allow-listed IEEE Xplore's 418 anti-bot response alongside the existing 403/429/999 exceptions for other publishers.
Verified with two workflow_dispatch runs on this branch: first run after fix #1 still failed on the second bug; run after fix #2 passed clean (run 31184596307).