Conversation
WillSewell
force-pushed
the
01-26-show_commitment_data
branch
from
de6df10 to
8aee18d
Compare
cxkoda
approved these changes
Jan 27, 2026
Comment on lines
+20
to
+35
| const walletTotals = new Map<Hex, bigint>(); | ||
| for (const item of amounts) { | ||
| const current = walletTotals.get(item.Wallet) ?? BigInt(0); | ||
| walletTotals.set(item.Wallet, current + BigInt(item.Amount)); | ||
| } | ||
|
|
||
| let topWallet = amounts[0].Wallet; | ||
| let topAmount = BigInt(0); | ||
| for (const [wallet, amount] of walletTotals) { | ||
| if (amount > topAmount) { | ||
| topAmount = amount; | ||
| topWallet = wallet; | ||
| } | ||
| } | ||
|
|
||
| return topWallet; |
Contributor
There was a problem hiding this comment.
this is a bit non-idiomatic. why not just .sort + taking the last? or something with .reduce?
| return amounts.reduce((sum, item) => sum + BigInt(item.Amount), BigInt(0)); | ||
| } | ||
|
|
||
| function findTopWallet(amounts: WalletTokenAmount[]): Hex { |
Contributor
There was a problem hiding this comment.
I think we should maybe discourage showing the address and just use the entity ID instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.