feat(typecheck): typecheck CREATE … AS query bodies - #789
Open
edjubert wants to merge 2 commits into
Open
Conversation
Extract and prepare the query body of CREATE TABLE AS, CREATE MATERIALIZED VIEW AS, and CREATE VIEW statements, then map PostgreSQL diagnostics back into the outer statement.
Verify that the inner create-query offset and the enclosing statement offset compose into the correct file-relative diagnostic range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature.
What is the current behavior?
Typechecking skips the query body of
CREATE TABLE AS,CREATE MATERIALIZED VIEW AS,and
CREATE VIEW AS.As a result, database errors inside the embedded
SELECTare not reported.Fixes #786.
What is the new behavior?
The typechecker now extracts and prepares the inner query of supported
CREATE … ASstatements without executing the outer DDL.
PostgreSQL diagnostics are mapped back to their original positions in the enclosing
SQL document. Valid create-as statements produce no diagnostic and do not create the
target table or view.
Additional context
Added regression coverage for:
CREATE TABLE AS;Validated with: