fix(diagnostics): prevent panics in indented multiline frames - #791
Open
edjubert wants to merge 2 commits into
Open
fix(diagnostics): prevent panics in indented multiline frames#791edjubert wants to merge 2 commits into
edjubert wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
Rendering a multiline syntax diagnostic can panic when its span ends at column zero
of an indented line.
This happens with a
WITHstatement followed by a blank line and an indented CTE.Fixes #785.
What is the new behavior?
Both diagnostic frame renderers clamp the last-line marker start to the span end
before constructing the range.
The CLI now reports the syntax diagnostic normally instead of panicking.
Additional context
Regression coverage includes:
Validation:
cargo test -p pgls_diagnosticscargo test -p pgls_cli check_indented_cte_after_blank_line_does_not_paniccargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warnings