fix(splitter): keep create-as CTEs attached - #793
Open
edjubert wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
CREATE TABLE AS,CREATE MATERIALIZED VIEW AS, andCREATE VIEW ASstatements whose query starts with a CTE are split before the final query.
This leaves PostgreSQL with an incomplete
CREATE ... AS WITH ...fragment andproduces a
syntax error at end of inputdiagnostic.What is the new behavior?
The statement splitter now keeps a CTE attached to its enclosing
CREATE ... ASstatement.
It also preserves
WITH (...)DDL options and correctly ends the CTE statementat its semicolon, without absorbing the following SQL statement.
Additional context
Added regression coverage for:
CREATE TABLE AS WITH ...;CREATE MATERIALIZED VIEW AS WITH ...;CREATE VIEW AS WITH ...;CREATE VIEW WITH (...) AS WITH ...;Validated with: