Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The splitter's
cterule expectedIDENT AS (. A CTE may also declare its output columns beforeAS, and that form made the rule bail out, so the statement was cut in two before the finalSELECT:Before this fix, everything up to the closing parenthesis of the CTE was submitted to the parser on its own, which reported
syntax error at end of inputon a perfectly valid file.Implementation
Three lines in
splitter/dml.rs: consume an optional parenthesised column list between the CTE name andAS.Why here
This extends
fix(splitter): keep create-as CTEs attached, whose test only covers a CTE whose body is aSELECT.The column-list form - most common with
VALUESlookup tables — was not covered.Tests
create_as_with_values_cteincrates/pgls_statement_splitter/src/lib.rs, using the exact statement above, asserting two statements and no errors.