fix: remove double NON_NULL wrapping on byPk argument types#635
Merged
utkarash2991 merged 1 commit intoMay 7, 2026
Merged
Conversation
imor
approved these changes
May 6, 2026
Contributor
imor
left a comment
imor
left a comment
There was a problem hiding this comment.
Approving to unblock. @utkarash2991 were you able to reproduce with GraphiQL?
Primary key columns are already wrapped in NonNull by sql_column_to_graphql_type for NOT NULL columns. The byPk argument construction was wrapping a second time unconditionally, producing NON_NULL(NON_NULL(Scalar)) which violates the GraphQL spec and breaks GraphiQL, Prisma, and code generators. Fix by checking if col_type is already NonNull before wrapping. View primary key columns (always nullable in PG) still get wrapped once. Fixes #633
utkarash2991
force-pushed
the
utkarashsingh/633-fix-double-non-null-bypk-args
branch
from
0622602 to
74babad
Compare
Contributor
Author
|
imor
approved these changes
May 7, 2026
Contributor
imor
left a comment
imor
left a comment
There was a problem hiding this comment.
Good to go, let's merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary key columns are already wrapped in NonNull by sql_column_to_graphql_type for NOT NULL columns. The byPk argument construction was wrapping a second time unconditionally, producing NON_NULL(NON_NULL(Scalar)) which violates the GraphQL spec and breaks GraphiQL, Prisma, and code generators.
Fix by checking if col_type is already NonNull before wrapping. View primary key columns (always nullable in PG) still get wrapped once.
Fixes #633
What kind of change does this PR introduce?
Bug fix