Skip to content

chore(sync): reconcile public source - #3910

Merged
caio-pizzol merged 1 commit into
mainfrom
chore/reconcile-public-source
Aug 14, 2026
Merged

chore(sync): reconcile public source#3910
caio-pizzol merged 1 commit into
mainfrom
chore/reconcile-public-source

Conversation

@caio-pizzol

@caio-pizzol caio-pizzol commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Update public package and migration metadata to the latest published versions.
  • Include the root-scroll positioning fix and its focused tests.
  • Disable the obsolete repository dispatcher while synchronization is paused.

Boundary

  • Materialized through the approved public-source projection.
  • Changes exactly nine public repository paths.
  • Contains no files or content outside the public source boundary.
  • Does not advance synchronization state or enable automation.

Verification

  • Projected tree: 7f7620973673636568d6033bce937f8ee257ca6b
  • Projection inputs: 2,418 public files, 0 non-public paths
  • Export seam verification: 531 files checked, 0 failures
  • git diff --check passes

Review in cubic

@caio-pizzol
caio-pizzol enabled auto-merge (squash) August 14, 2026 13:24

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 9 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@caio-pizzol
caio-pizzol disabled auto-merge August 14, 2026 13:25
@caio-pizzol
caio-pizzol merged commit 73e388c into main Aug 14, 2026
41 checks passed
@caio-pizzol
caio-pizzol deleted the chore/reconcile-public-source branch August 14, 2026 13:32
@linear-code

linear-code Bot commented Aug 14, 2026

Copy link
Copy Markdown

SD-4258

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) πŸ“˜ Rule violations (0) πŸ“œ Skill insights (0)



View medium (1)
🟠 **Medium**
1. Null scrollingElement test crash 🐞
Description
The new createRootScrollFixture() dereferences document.scrollingElement without a fallback; if it
is null/undefined, the test setup throws before any assertions run.
This is inconsistent with production code (which explicitly falls back to document.documentElement)
and can cause environment-specific CI failures.
Code

packages/superdoc/src/internal/toolbar/built-in/scroll-helpers.test.js[R33-36]

+  const container = document.scrollingElement;
+  Object.defineProperties(container, {
+    clientHeight: { configurable: true, value: 300 },
+    scrollHeight: { configurable: true, value: 1_000 },
Evidence
The test fixture assumes document.scrollingElement is always present, but the production
implementation explicitly treats it as optional by using a fallback to document.documentElement.
This mismatch means the new tests can fail in any environment where document.scrollingElement is
nullish.

packages/superdoc/src/internal/toolbar/built-in/scroll-helpers.test.js[30-38]
packages/superdoc/src/internal/toolbar/built-in/scroll-helpers.js[12-13]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The new root-scroll test fixture uses `document.scrollingElement` directly and then calls `Object.defineProperties(container, ...)`. If `document.scrollingElement` is nullish in the active DOM environment, the test will throw during fixture setup.

### Issue Context
Production code already treats `document.scrollingElement` as optional (`document.scrollingElement || document.documentElement`), so the test should mirror that defensive behavior.

### Fix
In `createRootScrollFixture`, set `container` using the same fallback as `getScrollableParent`:
- `const container = document.scrollingElement || document.documentElement;`

### Fix Focus Areas
- packages/superdoc/src/internal/toolbar/built-in/scroll-helpers.test.js[30-38]
- packages/superdoc/src/internal/toolbar/built-in/scroll-helpers.js[12-13]

β“˜ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Context
Review mode: βš–οΈ Balanced: The PR includes a localized runtime scrolling fix and tests plus workflow and package metadata changes; it has real behavioral and automation impact, but not enough independent logic to justify redundant extended review.

Tip of the day
πŸ’‘ Did you know, you can describe a rule in plain language on the Rules page and Qodo drafts it for you

More tips β†— | Customize Qodo β†— | Qodo docs β†—


Powered by Qodo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant