Fix GitHub App response processor to match GitHub's 201 status#53
Merged
Conversation
GitHub's installation token endpoint returns 201 Created on success, not 200 OK. The response processor was checking for 200 and silently passing the unwrapped response (containing the plaintext installation token) through to the caller, defeating the sealing protection. Tests still asserted 200 for the GitHub fixtures, so they passed despite the mismatch with the real API. Ref: https://docs.github.com/en/rest/apps/apps#create-an-installation-access-token-for-an-app
dangra
approved these changes
May 1, 2026
saleemrashid
reviewed
May 2, 2026
| if resp.StatusCode != http.StatusOK { | ||
| // GitHub's installation token endpoint returns 201 Created on success. | ||
| // https://docs.github.com/en/rest/apps/apps#create-an-installation-access-token-for-an-app | ||
| if resp.StatusCode != http.StatusCreated { |
Member
There was a problem hiding this comment.
We should check if it's between 200 and 299, given the failure mode is exposing the token. Maybe add a 200 test as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub's installation token endpoint returns 201 Created on success, not 200 OK. The response processor was checking for 200 and silently passing the unwrapped response (containing the plaintext installation token) through to the caller, defeating the sealing protection.
Tests still asserted 200 for the GitHub fixtures, so they passed despite the mismatch with the real API.
Ref: https://docs.github.com/en/rest/apps/apps#create-an-installation-access-token-for-an-app