Skip to content

Fix dead buy button when re-presenting a cached paywall after a purchase #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianrumac merged 12 commits into from
Jul 22, 2026
Merged

Fix dead buy button when re-presenting a cached paywall after a purchase #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a19238b
Fix dead buy button on cached paywall re-presentation
claude Jul 13, 2026
583fd9a
Update paywall preload benchmark report [skip ci]
github-actions[bot] Jul 13, 2026
be41e61
test(app): add FTL re-present regression tests for transient state reset
claude Jul 14, 2026
f5882e7
Update paywall preload benchmark report [skip ci]
github-actions[bot] Jul 14, 2026
532bfea
Move transient-state reset to PaywallManager cache-hit so embedded ge…
claude Jul 14, 2026
67440be
Update paywall preload benchmark report [skip ci]
github-actions[bot] Jul 14, 2026
a977aca
Ensure loading is reset after purchase
ianrumac Jul 21, 2026
716d63e
Update paywall preload benchmark report [skip ci]
github-actions[bot] Jul 21, 2026
9882774
Improve tests, cleanup comments
ianrumac Jul 22, 2026
dfa6e6e
Update paywall preload benchmark report [skip ci]
github-actions[bot] Jul 22, 2026
0964503
Improve tests, ensure getPresentationResult doesnt break live pw
ianrumac Jul 22, 2026
3e0586c
Ensure benchmark only runs on labels
ianrumac Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .benchmark/REPORT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ Time from `preloadAllPaywalls()` until every paywall reaches `PaywallLoadingStat

| Tier | Paywalls | Mean | Baseline | Δ | Limit | Cold mean | Warm mean | Median | StdDev | CV | Samples | Status |
|------|----------|------|----------|---|-------|-----------|-----------|--------|--------|----|---------|--------|
| LOW | 10 | 6.29s | 6.34s | -0.7% | +30% | 8.05s | — | 6.29s | 3.68s | 45.7% | 10 (10×1) | 🟢 improved |
| MID | 10 | 6.19s | 8.78s | -29.5% | +15% | 7.78s | — | 6.19s | 3.26s | 41.9% | 10 (10×1) | 🟢 improved |
| HIGH | 10 | 11.14s | 6.72s | +65.9% | +20% | 10.53s | — | 11.14s | 3.60s | 34.2% | 10 (10×1) | ❌ regression |
| LOW | 10 | 7.20s | 6.34s | +13.6% | +30% | 7.86s | — | 7.20s | 2.49s | 31.7% | 10 (10×1) | ✅ OK |
| MID | 10 | 6.03s | 8.78s | -31.3% | +15% | 6.92s | — | 6.03s | 2.76s | 40.0% | 10 (10×1) | 🟢 improved |
| HIGH | 10 | 6.36s | 6.72s | -5.3% | +20% | 6.73s | — | 6.36s | 2.21s | 32.8% | 10 (10×1) | 🟢 improved |

### Devices

Expand Down
274 changes: 137 additions & 137 deletions .benchmark/results/preload-benchmark-high.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,226 +11,226 @@
"runCount": 10,
"samples": [
{
"allReadyMs": 15509,
"allReadyMs": 12422,
"cold": true,
"configureMs": 3708,
"configureMs": 2614,
"index": 0,
"paywallCount": 10,
"perPaywallReadyMs": {
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 10547,
"data-v3-0ed9-2024-04-04": 11875,
"free-trial-v3-d8d7-2024-04-04": 15509,
"inimai---open-app-copy-c50c-2024-11-28": 9576,
"localized-paywall-e901-2024-04-04": 11364,
"price-tester-1b8e-2024-04-04": 12284,
"products-v3-60c5-2024-04-04": 12130,
"superwall-template-9f9f-2024-05-21": 9474,
"url-paywall-v3-3810-2024-04-04": 11109,
"video-v3-72b4-2024-04-04": 9985
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 12422,
"data-v3-0ed9-2024-04-04": 11606,
"free-trial-v3-d8d7-2024-04-04": 10149,
"inimai---open-app-copy-c50c-2024-11-28": 7040,
"localized-paywall-e901-2024-04-04": 10358,
"price-tester-1b8e-2024-04-04": 10875,
"products-v3-60c5-2024-04-04": 6888,
"superwall-template-9f9f-2024-05-21": 7706,
"url-paywall-v3-3810-2024-04-04": 8504,
"video-v3-72b4-2024-04-04": 10720
},
"preloadCompleteEventMs": 5184,
"preloadCompleteEventMs": 1928,
"run": 1
},
{
"allReadyMs": 10069,
"allReadyMs": 6417,
"cold": true,
"configureMs": 2039,
"configureMs": 1581,
"index": 0,
"paywallCount": 10,
"perPaywallReadyMs": {
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 7557,
"data-v3-0ed9-2024-04-04": 9914,
"free-trial-v3-d8d7-2024-04-04": 8327,
"inimai---open-app-copy-c50c-2024-11-28": 6251,
"localized-paywall-e901-2024-04-04": 7865,
"price-tester-1b8e-2024-04-04": 8429,
"products-v3-60c5-2024-04-04": 9304,
"superwall-template-9f9f-2024-05-21": 6662,
"url-paywall-v3-3810-2024-04-04": 9092,
"video-v3-72b4-2024-04-04": 10069
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 6011,
"data-v3-0ed9-2024-04-04": 6417,
"free-trial-v3-d8d7-2024-04-04": 5198,
"inimai---open-app-copy-c50c-2024-11-28": 4163,
"localized-paywall-e901-2024-04-04": 5300,
"price-tester-1b8e-2024-04-04": 4009,
"products-v3-60c5-2024-04-04": 5656,
"superwall-template-9f9f-2024-05-21": 4942,
"url-paywall-v3-3810-2024-04-04": 4576,
"video-v3-72b4-2024-04-04": 5503
},
"preloadCompleteEventMs": 1441,
"preloadCompleteEventMs": 1011,
"run": 2
},
{
"allReadyMs": 12216,
"allReadyMs": 7917,
"cold": true,
"configureMs": 3075,
"configureMs": 1980,
"index": 0,
"paywallCount": 10,
"perPaywallReadyMs": {
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 12216,
"data-v3-0ed9-2024-04-04": 10500,
"free-trial-v3-d8d7-2024-04-04": 6911,
"inimai---open-app-copy-c50c-2024-11-28": 7221,
"localized-paywall-e901-2024-04-04": 8575,
"price-tester-1b8e-2024-04-04": 6131,
"products-v3-60c5-2024-04-04": 11491,
"superwall-template-9f9f-2024-05-21": 8003,
"url-paywall-v3-3810-2024-04-04": 9304,
"video-v3-72b4-2024-04-04": 10866
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 7308,
"data-v3-0ed9-2024-04-04": 6902,
"free-trial-v3-d8d7-2024-04-04": 6291,
"inimai---open-app-copy-c50c-2024-11-28": 4787,
"localized-paywall-e901-2024-04-04": 7917,
"price-tester-1b8e-2024-04-04": 4635,
"products-v3-60c5-2024-04-04": 5723,
"superwall-template-9f9f-2024-05-21": 5211,
"url-paywall-v3-3810-2024-04-04": 6495,
"video-v3-72b4-2024-04-04": 7003
},
"preloadCompleteEventMs": 1835,
"preloadCompleteEventMs": 1539,
"run": 3
},
{
"allReadyMs": 14229,
"allReadyMs": 6911,
"cold": true,
"configureMs": 1909,
"configureMs": 2074,
"index": 0,
"paywallCount": 10,
"perPaywallReadyMs": {
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 10861,
"data-v3-0ed9-2024-04-04": 14229,
"free-trial-v3-d8d7-2024-04-04": 11915,
"inimai---open-app-copy-c50c-2024-11-28": 12433,
"localized-paywall-e901-2024-04-04": 11394,
"price-tester-1b8e-2024-04-04": 9931,
"products-v3-60c5-2024-04-04": 9263,
"superwall-template-9f9f-2024-05-21": 8115,
"url-paywall-v3-3810-2024-04-04": 6801,
"video-v3-72b4-2024-04-04": 10295
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 5795,
"data-v3-0ed9-2024-04-04": 6911,
"free-trial-v3-d8d7-2024-04-04": 4931,
"inimai---open-app-copy-c50c-2024-11-28": 4370,
"localized-paywall-e901-2024-04-04": 4728,
"price-tester-1b8e-2024-04-04": 4982,
"products-v3-60c5-2024-04-04": 5236,
"superwall-template-9f9f-2024-05-21": 4269,
"url-paywall-v3-3810-2024-04-04": 4576,
"video-v3-72b4-2024-04-04": 5134
},
"preloadCompleteEventMs": 1105,
"preloadCompleteEventMs": 1091,
"run": 4
},
{
"allReadyMs": 8974,
"allReadyMs": 6631,
"cold": true,
"configureMs": 2418,
"configureMs": 1404,
"index": 0,
"paywallCount": 10,
"perPaywallReadyMs": {
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 8414,
"data-v3-0ed9-2024-04-04": 8109,
"free-trial-v3-d8d7-2024-04-04": 6059,
"inimai---open-app-copy-c50c-2024-11-28": 8821,
"localized-paywall-e901-2024-04-04": 5696,
"price-tester-1b8e-2024-04-04": 7141,
"products-v3-60c5-2024-04-04": 7448,
"superwall-template-9f9f-2024-05-21": 6785,
"url-paywall-v3-3810-2024-04-04": 8974,
"video-v3-72b4-2024-04-04": 7702
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 6175,
"data-v3-0ed9-2024-04-04": 6631,
"free-trial-v3-d8d7-2024-04-04": 5364,
"inimai---open-app-copy-c50c-2024-11-28": 4533,
"localized-paywall-e901-2024-04-04": 5414,
"price-tester-1b8e-2024-04-04": 5668,
"products-v3-60c5-2024-04-04": 5820,
"superwall-template-9f9f-2024-05-21": 5059,
"url-paywall-v3-3810-2024-04-04": 5617,
"video-v3-72b4-2024-04-04": 5922
},
"preloadCompleteEventMs": 1570,
"preloadCompleteEventMs": 601,
"run": 5
},
{
"allReadyMs": 13263,
"allReadyMs": 5498,
"cold": true,
"configureMs": 2638,
"configureMs": 1391,
"index": 0,
"paywallCount": 10,
"perPaywallReadyMs": {
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 9505,
"data-v3-0ed9-2024-04-04": 8994,
"free-trial-v3-d8d7-2024-04-04": 13263,
"inimai---open-app-copy-c50c-2024-11-28": 7807,
"localized-paywall-e901-2024-04-04": 8268,
"price-tester-1b8e-2024-04-04": 11088,
"products-v3-60c5-2024-04-04": 9861,
"superwall-template-9f9f-2024-05-21": 10782,
"url-paywall-v3-3810-2024-04-04": 10065,
"video-v3-72b4-2024-04-04": 7604
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 5092,
"data-v3-0ed9-2024-04-04": 4585,
"free-trial-v3-d8d7-2024-04-04": 5396,
"inimai---open-app-copy-c50c-2024-11-28": 3773,
"localized-paywall-e901-2024-04-04": 5498,
"price-tester-1b8e-2024-04-04": 4281,
"products-v3-60c5-2024-04-04": 5244,
"superwall-template-9f9f-2024-05-21": 3672,
"url-paywall-v3-3810-2024-04-04": 4026,
"video-v3-72b4-2024-04-04": 3925
},
"preloadCompleteEventMs": 2635,
"preloadCompleteEventMs": 873,
"run": 6
},
{
"allReadyMs": 12855,
"allReadyMs": 5174,
"cold": true,
"configureMs": 2565,
"configureMs": 1793,
"index": 0,
"paywallCount": 10,
"perPaywallReadyMs": {
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 11426,
"data-v3-0ed9-2024-04-04": 12855,
"free-trial-v3-d8d7-2024-04-04": 10712,
"inimai---open-app-copy-c50c-2024-11-28": 8944,
"localized-paywall-e901-2024-04-04": 9926,
"price-tester-1b8e-2024-04-04": 11884,
"products-v3-60c5-2024-04-04": 9362,
"superwall-template-9f9f-2024-05-21": 8419,
"url-paywall-v3-3810-2024-04-04": 10916,
"video-v3-72b4-2024-04-04": 11527
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 4311,
"data-v3-0ed9-2024-04-04": 4565,
"free-trial-v3-d8d7-2024-04-04": 3803,
"inimai---open-app-copy-c50c-2024-11-28": 3549,
"localized-paywall-e901-2024-04-04": 5174,
"price-tester-1b8e-2024-04-04": 3447,
"products-v3-60c5-2024-04-04": 4717,
"superwall-template-9f9f-2024-05-21": 5022,
"url-paywall-v3-3810-2024-04-04": 4006,
"video-v3-72b4-2024-04-04": 3904
},
"preloadCompleteEventMs": 2529,
"preloadCompleteEventMs": 883,
"run": 7
},
{
"allReadyMs": 5826,
"allReadyMs": 5108,
"cold": true,
"configureMs": 1347,
"configureMs": 1656,
"index": 0,
"paywallCount": 10,
"perPaywallReadyMs": {
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 5213,
"data-v3-0ed9-2024-04-04": 5826,
"free-trial-v3-d8d7-2024-04-04": 4028,
"inimai---open-app-copy-c50c-2024-11-28": 3875,
"localized-paywall-e901-2024-04-04": 4435,
"price-tester-1b8e-2024-04-04": 4959,
"products-v3-60c5-2024-04-04": 3468,
"superwall-template-9f9f-2024-05-21": 3723,
"url-paywall-v3-3810-2024-04-04": 4334,
"video-v3-72b4-2024-04-04": 4180
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 4552,
"data-v3-0ed9-2024-04-04": 4805,
"free-trial-v3-d8d7-2024-04-04": 4197,
"inimai---open-app-copy-c50c-2024-11-28": 3324,
"localized-paywall-e901-2024-04-04": 3631,
"price-tester-1b8e-2024-04-04": 4247,
"products-v3-60c5-2024-04-04": 3222,
"superwall-template-9f9f-2024-05-21": 5108,
"url-paywall-v3-3810-2024-04-04": 3476,
"video-v3-72b4-2024-04-04": 4044
},
"preloadCompleteEventMs": 965,
"preloadCompleteEventMs": 589,
"run": 8
},
{
"allReadyMs": 6134,
"allReadyMs": 6305,
"cold": true,
"configureMs": 1891,
"configureMs": 1512,
"index": 0,
"paywallCount": 10,
"perPaywallReadyMs": {
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 6134,
"data-v3-0ed9-2024-04-04": 5626,
"free-trial-v3-d8d7-2024-04-04": 5066,
"inimai---open-app-copy-c50c-2024-11-28": 4200,
"localized-paywall-e901-2024-04-04": 5117,
"price-tester-1b8e-2024-04-04": 4353,
"products-v3-60c5-2024-04-04": 4036,
"superwall-template-9f9f-2024-05-21": 4710,
"url-paywall-v3-3810-2024-04-04": 5779,
"video-v3-72b4-2024-04-04": 5320
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 4071,
"data-v3-0ed9-2024-04-04": 6305,
"free-trial-v3-d8d7-2024-04-04": 4782,
"inimai---open-app-copy-c50c-2024-11-28": 4884,
"localized-paywall-e901-2024-04-04": 5441,
"price-tester-1b8e-2024-04-04": 4122,
"products-v3-60c5-2024-04-04": 4985,
"superwall-template-9f9f-2024-05-21": 4478,
"url-paywall-v3-3810-2024-04-04": 4630,
"video-v3-72b4-2024-04-04": 3513
},
"preloadCompleteEventMs": 1278,
"preloadCompleteEventMs": 1152,
"run": 9
},
{
"allReadyMs": 6223,
"allReadyMs": 4940,
"cold": true,
"configureMs": 1722,
"configureMs": 1820,
"index": 0,
"paywallCount": 10,
"perPaywallReadyMs": {
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 6223,
"data-v3-0ed9-2024-04-04": 5919,
"free-trial-v3-d8d7-2024-04-04": 4466,
"inimai---open-app-copy-c50c-2024-11-28": 4008,
"localized-paywall-e901-2024-04-04": 5088,
"price-tester-1b8e-2024-04-04": 5456,
"products-v3-60c5-2024-04-04": 4986,
"superwall-template-9f9f-2024-05-21": 4212,
"url-paywall-v3-3810-2024-04-04": 5240,
"video-v3-72b4-2024-04-04": 5393
"based-on-teleprompter-bigvu-template-2b72-2024-04-04": 4028,
"data-v3-0ed9-2024-04-04": 4940,
"free-trial-v3-d8d7-2024-04-04": 3774,
"inimai---open-app-copy-c50c-2024-11-28": 3113,
"localized-paywall-e901-2024-04-04": 4231,
"price-tester-1b8e-2024-04-04": 2962,
"products-v3-60c5-2024-04-04": 4180,
"superwall-template-9f9f-2024-05-21": 4585,
"url-paywall-v3-3810-2024-04-04": 3521,
"video-v3-72b4-2024-04-04": 3266
},
"preloadCompleteEventMs": 1276,
"preloadCompleteEventMs": 594,
"run": 10
}
],
"schemaVersion": 1,
"stats": {
"coefficientOfVariationPct": 34.216062455209986,
"coldMeanMs": 10529.8,
"maxMs": 15509,
"meanMs": 10529.8,
"medianMs": 11142.5,
"minMs": 5826,
"coefficientOfVariationPct": 32.806642844462296,
"coldMeanMs": 6732.3,
"maxMs": 12422,
"meanMs": 6732.3,
"medianMs": 6361.0,
"minMs": 4940,
"sampleCount": 10,
"stdDevMs": 3602.8829444087014,
"stdDevMs": 2208.641616217735,
"warmMeanMs": null
},
"tier": "HIGH"
Expand Down
Loading
Loading