Bump SuperwallSDK.androidlib compileSdk to 35 (fixes checkReleaseAarMetadata failure)#4
Open
bilck wants to merge 1 commit into
Open
Bump SuperwallSDK.androidlib compileSdk to 35 (fixes checkReleaseAarMetadata failure)#4bilck wants to merge 1 commit into
bilck wants to merge 1 commit into
Conversation
superwall-android 2.+ currently resolves to 2.7.21, which pulls in androidx.activity 1.10.1. That artifact's AAR metadata declares minCompileSdk=35, so every Unity Android export now fails at :unityLibrary:SuperwallSDK.androidlib:checkReleaseAarMetadata while the module compiles against android-34. compileSdk only affects compile-time API visibility (not minSdk device support or targetSdk runtime behavior), so this is safe for all consumers - and consumers on current 2.+ resolutions cannot build without it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SuperwallSDK.androidlib/build.gradlehardcodescompileSdkVersion 34, but its floating dependencyapi 'com.superwall.sdk:superwall-android:2.+'currently resolves to 2.7.21, which transitively pullsandroidx.activity:activity[-ktx]:1.10.1. That artifact's AAR metadata declaresminCompileSdk=35, so every Unity Android export now fails:This started breaking builds with zero changes on the consumer side - Gradle simply re-resolved
2.+to the new release. Reproduced on Unity 6000.4 / AGP 9.0, but it affects any consumer whose dependency cache refreshes.Fix
One line:
compileSdkVersion 34→compileSdkVersion 35. Chosen as the smallest possible change:compileSdkonly affects compile-time API visibility - it does not changeminSdk(device support) ortargetSdk(runtime behavior), so no consumer-facing behavior changes.compileSdkVersionDSL spelling, so no change to the AGP version range the module works on today.2.+resolutions cannot build at all without this, so it can't regress anyone.Alternatives you may prefer (happy to rework the PR)
gradle.properties, socompileSdk (findProperty("unity.compileSdkVersion") ?: 35) as intkeeps the module permanently aligned with the app's Player Settings and avoids the next bump. (ThecompileSdkDSL needs AGP 7.0+, which the file's existingnamespaceDSL already requires.)superwall-androidto an exact version per Unity SDK release instead of2.+. The floating range is the root cause here: a Maven-side release changed every consumer's build overnight. An exact pin makes Android SDK bumps deliberate and releases reproducible.Related (separate issue, not in this PR)
Under AGP 9.0 (Unity 6.4 default), the module's
buildscript+apply plugin: 'kotlin-android'wiring crashes Gradle evaluation (LibraryExtensionImplno longer inherits fromBaseExtension); AGP 9's built-in Kotlin support makes it unnecessary there, but older AGP still needs it. We currently strip it at export time with anIPostGenerateGradleAndroidProjectpost-processor on our side - can share that or open a follow-up issue if useful.🤖 Generated with Claude Code