Add Public Domain image link#17
Open
ghost wants to merge 1 commit into
Open
Conversation
Added the image gallery from Public Domain Pictures to the click here button
ghost
self-assigned this
ghost
requested review from
KMcWeeney22,
hlkessner,
kevinsheen,
lariosw and
lukevpoel
Author
|
Should we try to link the categories to those of the poetry author section? |
kevinsheen
reviewed
Feb 11, 2017
| <h2>Heading</h2> | ||
| <p>Donec sed odio dui. Cras justo odio, dapibus ac facilisis in, egestas eget quam. Vestibulum id ligula porta felis euismod semper. Fusce dapibus, tellus ac cursus commodo, tortor mauris condimentum nibh, ut fermentum massa justo sit amet risus.</p> | ||
| <p><a class="btn btn-default" href="#" role="button">View details »</a></p> | ||
| <p><a class="btn btn-default" href="http://www.publicdomainpictures.net/browse-category.php?c=people&s=8" role="button">View details »</a></p> |
Collaborator
There was a problem hiding this comment.
Public domain link looks good! I agree that we should link categories to poetry author section.
Author
There was a problem hiding this comment.
Great, I'll work on that next week.
lariosw
approved these changes
Feb 12, 2017
lariosw
left a comment
lariosw
left a comment
Collaborator
There was a problem hiding this comment.
That sounds like a good idea. The link looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the href tag for theimage gallery from Public Domain Pictures to the click here
button. Task is to start working on issue: #4
Still need to work on adding categories that are relevant to the user.