Featured.poet#26
Conversation
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
The featured poet sections look good on the site and nice brief statement. We can work on the links to add to the View Details button!
| </form> | ||
| <ul class="nav navbar-nav navbar-right"> | ||
| <li class="dropdown"> | ||
| <a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false">About Us <span class="caret"></span></a> |
| <span class="icon-bar"></span> | ||
| <span class="icon-bar"></span> | ||
| </button> | ||
| <a class="navbar-brand" href="#">Traquil Prestige</a> |
There was a problem hiding this comment.
Title correction: Tranquil Prestige and good to go for merging!
There was a problem hiding this comment.
Hey there, I really like the addition of the featured poets section, as I believe it can also be a rotating part of our poetry site. Adding different featured artists throughout the month potentially to create a consistent update for users would be interesting as well. The HTML looks good and your poet descriptions read nicely, giving a nice preview of their work and a little personal background information. I like that you added some of their quotes into the descriptions to round it out. We can even have that button include more information on each featured poet as well if we decide to expand them. Which if they have their own separate pages, then that may fit nicely. I approve of this pull request and merging to the master branch! -Kevin
| <p><a class="btn btn-default" href="#" role="button">View details »</a></p> | ||
| <h2>Alfred Tennyson</h2> | ||
| <p>Tennyson remains one of the most popular poets of the English Language. His themes range from mythology to the every day. Learn why "'Tis better to have loved and lost / Than never to have loved at all"</p> | ||
| <p><a class="btn btn-default" href="#" role="button">View Details »</a></p> |
There was a problem hiding this comment.
Perhaps this buttons can have access to additional information down the road. Kind of open it up a little bit more for users.
| <div class="row"> | ||
| <h1> | ||
| Featured Poets | ||
| </h1> |
There was a problem hiding this comment.
Your code looks good and is nicely laid out for an easy reading of each poet.
| <h2>Heading</h2> | ||
| <p>Donec sed odio dui. Cras justo odio, dapibus ac facilisis in, egestas eget quam. Vestibulum id ligula porta felis euismod semper. Fusce dapibus, tellus ac cursus commodo, tortor mauris condimentum nibh, ut fermentum massa justo sit amet risus.</p> | ||
| <h2>Czeslaw Milosz</h2> | ||
| <p>Milosz is widely considered one of the greatest poets of the 21st century. He won the Pulitzer Prize in 1980 despite the trials he faced durring the Cold War. Learn why he was called "Righteous among the Nations."</p> |
There was a problem hiding this comment.
Looks good! Thanks for adding in actual content for the site!
3 participants
URL to the issue this pull request is associated with.: #5
In order to close this issue, I would like to incorporate local storage to save the poet or poetry the user was last reading about and suggest that they pick up where they left off when they come back to the site. I would also like to incorporate a feature that will suggest recommended poets to the user based on what they have looked at in the past.