Refactor Akinci surface tension foundations - #39
Closed
svchb wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Superseded by trixi-framework#1253, which targets upstream main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CohesionForceAkincino longer allocates or computes unused normalsColorfieldSurfaceNormalthreshold types and skip the Morris capillary restriction for a zero coefficientStack
This is PR 1 of the surface-tension refactoring stack. It targets
bug_fixed. Follow-up PRs will address Morris geometry/CSF, CSS interaction conservation and diagnostics, then model comparison and validation cases.Findings addressed
DomainErrorVerification
git diff --checkpassedNotes
The oil-film example keeps surface tension disabled until the explicit two-phase interaction policy is implemented in PR 3. The published Akinci normalization is retained for compatibility and documented as empirical in 2D.