[needs review] sweep sweep/tags-2026-08-11-10: 3 tag fix(es) across 2 squad(s) - #694
Closed
swackhamer wants to merge 6 commits into
Closed
[needs review] sweep sweep/tags-2026-08-11-10: 3 tag fix(es) across 2 squad(s)#694swackhamer wants to merge 6 commits into
swackhamer wants to merge 6 commits into
Conversation
Format: DJVU
Tag: DjVu:Note
Sample: /tmp/oxidex-exiftool-cache/combined-samples/DjVu.djvu
Exiftool-Value: 'Must escape double quotes (") and backslashes (\\)'
Oxidex-Value: 'Must escape double quotes (") and backslashes (\\)'
Verified: recheck-pass gaps=1->0
Worker: tail-9
Format: APE Tag: Composite:Duration Sample: /tmp/oxidex-exiftool-cache/combined-samples/APE.ape Exiftool-Value: '2.64 s' Oxidex-Value: '2.64 s' Perl-Ref: APE.pm Verified: recheck-pass gaps=1->0 Worker: tail-5
Format: BPG Tag: XMP:ComponentsConfiguration Sample: /tmp/oxidex-exiftool-cache/combined-samples/BPG.bpg Exiftool-Value: 'Y, Cb, Cr, -' Oxidex-Value: 'Y, Cb, Cr, -' Perl-Ref: Exif.pm Verified: recheck-pass gaps=1->0 Worker: xmp-1
Worker-authored Rust reaches this branch semantically validated but never style-checked: validate_fix_commit.py, the per-commit merger check and the post-merge recheck all assert behaviour (gap deltas, no duplicate emissions, no unexplained oxidex-only keys) and none of them look at formatting. CI's "Lint & Audit" job runs `cargo fmt --all -- --check`, so an unformatted sweep branch fails CI by construction. Measured on PR #124 (branch sweep/tags-2026-07-26-1, the first sweep PR ever opened): CI run 30186389305 -- "Build & Test" success, "Lint & Audit" failure, and the failing step is literally `Run cargo fmt --all -- --check`. Kept as a separate commit so the tag-fix diffs stay readable.
swackhamer
added a commit
that referenced
this pull request
Aug 11, 2026
…695) Second follow-up to #691/#693. Measured 2026-08-11 in production: PR #694 duplicated #692 (byte-identical diffs, md5-verified) despite #693's path-scoped duplicate check. The scoped diff DID find a difference -- but it was pure rustfmt whitespace (a 3-line match arm collapsed to one line), nothing semantic. #692's branch had already been through format_sweep_branch's fmt-and-commit step in its own round; this round's comparison ran on raw, pre-fmt worker output, because both idempotency checks (origin_ref and the open-PR one) are commit-to-commit diffs that only ever compare what THIS round has committed so far -- which, at that point in run_sweep, has never been through fmt. Unformatted content can never tree-match a PR that already went through fmt, no matter how many times the same gap gets re-solved with functionally identical code. Fix: run format_sweep_branch once, early -- right before the origin_ref zero-delta check -- so both idempotency checks compare already-formatted content. The later format_sweep_branch call (after the evidence table / judgment queue are built, where it has always lived) is usually now a no-op ("already cargo-fmt clean"); kept in place because commits_contributed resolves each squad's contribution from merge_infos boundaries recorded before any fmt call, so an early fmt commit can never leak into the evidence table regardless of when it happens -- but the evidence table's own construction still must not move earlier than it already is. New regression test reproduces the exact #694-vs-#692 shape: the already-open PR's branch carries the fmt-normalized form of a fix, this round's squad commit carries the identical fix pre-fmt. Confirmed the test fails against the pre-fix code and passes with this fix. One existing assertion (which of the two format_sweep_branch calls reports "committed") updated to match: the commit now happens at the earlier call, so the later one correctly reports false. Full suite: 103 tests green.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sweep sweep/tags-2026-08-11-10
Evidence table
Judgment queue
No commits in this sweep require judgment-queue review -- everything ships mechanically.