refactor(llmagent)!: require a positive model call limit - #29
Merged
Merged
Conversation
Remove the implicit ten-call default and reject MaxModelCalls values less than or equal to zero. Update callers and tests to configure explicit positive limits. BREAKING CHANGE: llmagent.New now rejects omitted or zero MaxModelCalls. Callers must set a positive limit; use 10 to preserve the previous default.
uterflec
added
refactor
ktsoator
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Omitting MaxModelCalls previously selected an implicit limit of 10. Require an explicit positive limit and reject zero or negative values in llmagent.New.
Update the assistant example and tests to supply explicit limits, and cover zero rejection and the existing call-limit behavior. This is a breaking configuration change: callers that relied on the default must set MaxModelCalls to a positive value (10 preserves the previous behavior).
Validation: go vet and all tests passed with the race detector.