refactor(model)!: require a name on the llm interface - #30
Merged
Merged
Conversation
Add Name to model.LLM to expose the configured model ID directly. Update the OpenAI adapter and test models, and simplify the agent's ModelName method to call Name without a type assertion. BREAKING CHANGE: model.LLM implementations must provide Name() string. The OpenAI adapter's ModelName method is renamed to Name.
uterflec
added
refactor
ktsoator
self-requested a review
September 24, 2026 09:41
ktsoator
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model IDs were exposed through an optional method and a runtime type assertion. Require Name() string on model.LLM so agents can retrieve the configured model ID directly.
Update the OpenAI adapter and test models, and simplify llmAgent.ModelName. Custom model implementations must add Name(); the OpenAI adapter's ModelName method is renamed to Name.
Validation: go vet and all tests passed with the race detector.