You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Documentation(859517): Review and improve Blazorcons documentation for icon customization guidance and sample correctness
Issue
The Blazor Message Icons documentation contains several inconsistencies and sample-related issues. The Custom Icon section recommends using the CssClass property for icon customization without mentioning the dedicated IconCss property. Additionally, the sample includes an embedded Base64 @font-face definition, making it difficult to understand and reproduce. Other reported issues include an incorrect event binding in the Close Icon sample, unused code variables, inconsistent page content, direct styling of internal component classes, and grammatical inaccuracies in sample text.
Solution
Reviewed the documentation and updated the content to improve clarity and maintainability. The documentation now highlights the recommended approach for icon customization, removes unnecessary complexity from the samples, corrects sample issues and content inconsistencies, improves styling guidance by avoiding direct dependency on internal classes, and fixes grammatical and code-related errors in the examples. These changes ensure that the documentation is easier to understand, reproducible, and aligned with current component capabilities.
CI Status: SUCCESS ✅ Source Compilation: SUCCESS ✅ Build Location: 859517-message Technical Error(s): 0 Spelling Error(s): 0 Image Alt Text Error(s): 0 Image Size Error(s): 0 Image Name Error(s): 0 Front matter Error(s): 0 File Path Error(s): 0 CodeSnippet File Path Missing Error(s): 0 Toc Anchor Tags Validation Error(s): 0 MD Tag Validation Error(s): 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documentation(859517): Review and improve Blazorcons documentation for icon customization guidance and sample correctness
Issue
The Blazor Message Icons documentation contains several inconsistencies and sample-related issues. The Custom Icon section recommends using the
CssClassproperty for icon customization without mentioning the dedicatedIconCssproperty. Additionally, the sample includes an embedded Base64@font-facedefinition, making it difficult to understand and reproduce. Other reported issues include an incorrect event binding in the Close Icon sample, unused code variables, inconsistent page content, direct styling of internal component classes, and grammatical inaccuracies in sample text.Solution
Reviewed the documentation and updated the content to improve clarity and maintainability. The documentation now highlights the recommended approach for icon customization, removes unnecessary complexity from the samples, corrects sample issues and content inconsistencies, improves styling guidance by avoiding direct dependency on internal classes, and fixes grammatical and code-related errors in the examples. These changes ensure that the documentation is easier to understand, reproducible, and aligned with current component capabilities.
Code Studio usage(Mandatory)
Code Studio used in this PR/MR?
If
Yes: Primary use (choose one)Outcome
If “Cost time” explain in short (1 or 2 lines):
Type of Change
Reviewer Checklist (Mandatory)