fix: polish widgets foundation#946
Open
ovitrif wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #936
Description
This PR:
$$on phones with non-US locale.Preview
todo: <!-- VIDEO_1: Widget picker/config flow showing wide-only in-app previews, Facts tap opening Bitkit, and settings-capable OS widgets showing Widget settings on long press. -->QA Notes
Manual Tests
regression:Android home → tap Price/Headlines/Blocks/Weather OS widget: widget settings still open for configurable widgets.regression:Android home → add Price OS widget with BTC/USD: the widget shows one currency symbol, not a duplicated symbol like$ $81,444.Automated Checks
./gradlew compileDevDebugKotlin./gradlew testDevDebugUnitTest./gradlew detekt./gradlew compileDevDebugAndroidTestKotlin./gradlew installDevDebug, then launchedto.bitkit.dev/to.bitkit.ui.MainActivityon Pixel 10 Pro; app process stayed up and the crash buffer was empty.app/src/androidTest/java/to/bitkit/ui/screens/widgets/headlines/HeadlinesPreviewContentTest.kt.app/src/test/java/to/bitkit/data/widgets/PriceServiceTest.kt.