fix: review findings on release gates (#1-#5, #7-#8, #10-#12) - #19
Open
systemfsoftware-maker wants to merge 1 commit into
Open
fix: review findings on release gates (#1-#5, #7-#8, #10-#12)#19systemfsoftware-maker wants to merge 1 commit into
systemfsoftware-maker wants to merge 1 commit into
Conversation
Metadata gate: --argjson want so the os/cpu/libc object comparison is meaningful (was always false, blocking every release); package name uses LAUNCHER_NAME (was undefined LAUNCHER); non-empty assertions. Concurrency keyed by tag ref with cancel-in-progress so a force-moved tag re-runs in a fresh lane while two runs of the same tag can never publish the same version twice. Publish order: root launcher now publishes BEFORE the platform packages so their exact launcher peerDependencies resolve; a final verify-release job runs the metadata gate, three-way digest cross-check and root pin check after every publish and the GitHub release upload. check-matrix: matrixRows reads only the named release job (no decoy-job acceptance), rejects empty/malformed include rows, and compares the per-row runner against targets.json; targets.json carries the canonical runner and check-matrix validates it against the known-runner set. Cross-check: set -euo pipefail, exactly-one-binary and non-empty guard, non-empty sidecar guard, bounded retries for gh release download matching npm pack. Exit-code contract: smoke payloads are byte-identical to the Rust constants; new release-smoke.test.ts pins the workflow's -eq 0/-eq 2 assertions and payload bytes so tag-time drift breaks CI instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 10 findings from the post-merge code review of #18.
P0
--arg want) →--argjson want; gate now exits 0 on a healthy platform package and 1 on any mismatch (probed locally against both shapes). This was blocking every tagged release.P1
$LAUNCHER→$LAUNCHER_NAME+ non-empty assertions.github.sha→github.ref+cancel-in-progress: true: force-moved tags re-run in a fresh lane; two runs of the same tag can never double-publish.releasejob (a decoy matrix no longer satisfies the gate), rejects empty/malformed include rows, compares per-rowrunneragainsttargets.jsoncanonical runners.P2
verify-releaseruns the metadata gate + three-way digest cross-check + root pin check after every publish and the GitHub release upload.set -euo pipefail, exactly-one-binary and non-empty guards, non-empty sidecar guard, bounded retry forgh release downloadmatchingnpm pack.P3
exit_codes.rsconstants; newrelease-smoke.test.tspins the workflow's-eq 0/-eq 2assertions and payload bytes.Verification: scripts deno test 10/10, lint clean, check-matrix ok; cargo fmt/clippy/test green; actionlint clean on both workflows; metadata-gate jq probed (match exit 0, mismatch exit 1, darwin no-libc shape exit 0).
Closes: #3
Closes: #4
Closes: #5
Closes: #6
Closes: #7
Closes: #8
Closes: #9