Enable SCSS important @apply migration test

[Shatlyk1011]

The upgrade codemod already supports Sass/SCSS interpolation syntax when migrating @apply ... #{!important} to postfix important utilities, but the corresponding test was still skipped with a stale TODO.

[greptile-apps]

Confidence Score: 5/5

The change is limited to a test file, removes a skip, and adds no production code — safe to merge.

Only the test file changes. The new migrateRoot helper correctly targets the plugin's OnceExit handler, the manual AST manipulation accurately reproduces the SCSS interpolation string the production code already handles, and the extracted loadDesignSystem helper reduces duplication without altering any behavior.

No files require special attention.

_{Reviews (1): Last reviewed commit: "Enable SCSS important @apply migration t..." | Re-trigger Greptile}

[coderabbitai]

Walkthrough

This PR refactors the test harness for the migrateAtApply PostCSS plugin codemod. The test helpers are updated to load the Tailwind design system asynchronously via a new loadDesignSystem() function, and a migrateRoot() helper is introduced to invoke the plugin's optional OnceExit hook. A previously skipped test case for @apply utilities with #{!important} SCSS interpolation is converted to an active test by manually constructing the PostCSS AST to bypass parser rejection of the interpolation syntax, then asserting the migrated output.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Enable SCSS important @apply migration test' directly and clearly describes the main change - enabling a previously skipped test for SCSS @apply migration.
Description check	✅ Passed	The description clearly explains that the PR enables a previously skipped test for SCSS interpolation in @apply migration, which relates directly to the changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

packages/@tailwindcss-upgrade/src/codemods/css/migrate-at-apply.test.ts (1)

35-49: ⚡ Quick win

Memoize design-system loading to avoid repeated expensive test setup.

loadDesignSystem() currently rebuilds the design system on every call from migrate()/migrateRoot(). Caching the promise keeps behavior the same and speeds up this test file noticeably.

Proposed diff

+let designSystemPromise: ReturnType<typeof __unstable__loadDesignSystem> | null = null
+
 async function loadDesignSystem() {
-  let designSystem = await __unstable__loadDesignSystem(
-    css`
-      `@import` 'tailwindcss';
-
-      /* TODO(perf): Only here to speed up the tests */
-      `@theme` {
-        --*: initial;
-      }
-    `,
-    { base: __dirname },
-  )
-
-  return designSystem
+  return (designSystemPromise ??= __unstable__loadDesignSystem(
+    css`
+      `@import` 'tailwindcss';
+
+      /* TODO(perf): Only here to speed up the tests */
+      `@theme` {
+        --*: initial;
+      }
+    `,
+    { base: __dirname },
+  ))
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/`@tailwindcss-upgrade/src/codemods/css/migrate-at-apply.test.ts
around lines 35 - 49, The loadDesignSystem() helper rebuilds the design system
on every invocation; memoize the creation promise so subsequent calls reuse the
same design system. Add a module-scoped variable (e.g.,
cachedDesignSystemPromise) and have loadDesignSystem return that promise if set;
otherwise call __unstable__loadDesignSystem(css`...`, { base: __dirname }),
store the returned promise in cachedDesignSystemPromise, and return it. Ensure
the behavior and returned value remain identical to callers of migrate() and
migrateRoot().

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@packages/`@tailwindcss-upgrade/src/codemods/css/migrate-at-apply.test.ts:
- Around line 35-49: The loadDesignSystem() helper rebuilds the design system on
every invocation; memoize the creation promise so subsequent calls reuse the
same design system. Add a module-scoped variable (e.g.,
cachedDesignSystemPromise) and have loadDesignSystem return that promise if set;
otherwise call __unstable__loadDesignSystem(css`...`, { base: __dirname }),
store the returned promise in cachedDesignSystemPromise, and return it. Ensure
the behavior and returned value remain identical to callers of migrate() and
migrateRoot().

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bf841e6c-604d-4d6e-b277-fbf37588f4a6

📥 Commits

Reviewing files that changed from the base of the PR and between 982e920 and b5b3711.

📒 Files selected for processing (1)

• packages/@tailwindcss-upgrade/src/codemods/css/migrate-at-apply.test.ts