Add canonical streaming adapter layer for OpenAI - #40
Merged
Conversation
Review BriefTask
Risk
Scope
CoverageCoverage report not found. Run pytest with --cov to generate coverage.xml. API changesAdded functions
Added classes
Removed classes
ContractsNo contract tests changed. High-risk change — run Notes
|
1 similar comment
Review BriefTask
Risk
Scope
CoverageCoverage report not found. Run pytest with --cov to generate coverage.xml. API changesAdded functions
Added classes
Removed classes
ContractsNo contract tests changed. High-risk change — run Notes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
foundry.adaptersTesting
pytest tests/test_openai_adapter_contract.py tests/test_openai_adapter_parity.py tests/test_openai_adapter_edges.py -qpytest tests/adapters -qruff check src/foundry/adapters tests/test_openai_adapter_contract.py tests/test_openai_adapter_parity.py tests/test_openai_adapter_edges.pymypy src/foundry/adapterspytest -q(fails: missing optional dependencypydanticfor unrelated IO tests)Closes #32
https://chatgpt.com/codex/tasks/task_e_68fb01a98ab08322aee133798fb3f068