fix: isolate soak environment from normal launch - #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep benchmark-only soak settings out of normal Hyperwall launches.
launch.shnow clears stale soak-only environment variables unless an explicit soak marker is present.soak_wall.shandrun-soak-diagnostics.pyset that marker before starting a soak.This prevents an ordinary launch from unexpectedly becoming a randomized, self-terminating diagnostic run after benchmark work in the same shell.
Verification
bash -n launch.sh soak_wall.sh— pass.python3 tests/run_all.py— overall PASS.