docs(cf): document pool read-isolation limitation + multi-pool guidance#67
Merged
Conversation
CF search/findByIds ignore knowledgePool, so multiple pools sharing one binding
are not read-isolated (a query for one pool can return another's vectors).
deleteChunks/hasEmbeddingVersion scope correctly; pg/mongodb isolate reads by
pool — CF is the outlier.
- Rewrite "Multiple Knowledge Pools": the adapter is effectively single-pool
today (one binding, one dbAdapter; a second plugin invocation overwrites the
first), replacing the prior two-integration example that doesn't actually work.
- Document workarounds: separate deployments for true isolation, or
application-layer filtering (id prefix, or a discriminator extensionField via
search's where).
- Add a "help wanted" ask for a { knowledgePool: binding } map for native
multi-pool support.
- Add a Known Limitations bullet naming the read leak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation-only. Splits the CF README docs out of #62 (findByIds) into their own PR.
CF
search/findByIdsignoreknowledgePool, so multiple pools sharing one binding are not read-isolated — a query for one pool can return another pool's vectors.deleteChunks/hasEmbeddingVersionscope correctly, and pg/mongodb isolate reads by pool (each pool is a separate table/collection), so CF is the outlier.Changes (adapters/cf/README.md)
dbAdapter; a secondpayloadcmsVectorize(...)invocation overwrites the first). Replaces the prior two-integration example, which doesn't actually work.extensionFieldviasearch'swhere; notefindByIdshas nowhere).{ knowledgePool: binding }map for native multi-pool support (real per-pool isolation + per-pool dims).No code changes; behavior is unchanged. Base
main.