feat(client): Add injectable structured logging - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inject a swift-log
Loggerinto the documentation client and add structured events across fetching, canonical fallbacks, search traversal, and failures. Expected misses and cancellations stay below error level, while request metadata includes paths, status codes, response sizes, and timing without logging response bodies or URL credentials.Logging bootstrap, console output, and Sentry filtering remain unchanged. Tests capture events through a
LogHandlerbacked bySynchronization.Mutex, with macOS 15 availability limited to the new logging tests.Verification
Passed 87 unit tests,
make analyze, andmake build. Release view and search smoke tests returned valid JSON with empty stderr while telemetry was disabled.