feat(homebrew): Add completions and template validation - #4
Merged
Merged
Conversation
philprime
marked this pull request as ready for review
September 13, 2026 14:04
Member
Author
|
@sentry review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install Bash, Zsh, and Fish completions for apple-docs, declare its license and macOS 13 minimum, and exercise bundled skills and completion files in the formula test. Revision 1 applies only to version 0.0.4 so existing installations can receive the packaging update.
Share a validated renderer between publishing and a read-only PR workflow. Check rendering, Ruby syntax, invalid metadata, platform-specific URLs and checksums, and revision reset behavior before template changes reach the tap. Full installation testing remains in homebrew-tap.
Verification
make test-homebrew, Ruby syntax checks, workflow validation, formatting, and pre-commit checks passed. Completion generation and bundled skill commands were checked with the released macOS ARM64 binary. The fullmake testrun stopped at the existing RPM suite becauserpmbuildis unavailable locally.